Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modularity to return result for louvain #2706

Merged

Conversation

ChuckHastings
Copy link
Collaborator

The C API defined for Louvain was missing the modularity score. Add the modularity score to the result and add an accessor that allows the modularity score to be accessed.

@ChuckHastings ChuckHastings requested a review from a team as a code owner September 19, 2022 17:36
@ChuckHastings ChuckHastings self-assigned this Sep 19, 2022
@ChuckHastings ChuckHastings added 3 - Ready for Review bug Something isn't working non-breaking Non-breaking change labels Sep 19, 2022
@ChuckHastings ChuckHastings added this to the 22.10 milestone Sep 19, 2022
@ChuckHastings
Copy link
Collaborator Author

rerun tests

@codecov-commenter
Copy link

Codecov Report

Base: 60.16% // Head: 60.16% // No change to project coverage 👍

Coverage data is based on head (1581d89) compared to base (3537690).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-22.10    #2706   +/-   ##
=============================================
  Coverage         60.16%   60.16%           
=============================================
  Files               111      111           
  Lines              6123     6123           
=============================================
  Hits               3684     3684           
  Misses             2439     2439           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1232037 into rapidsai:branch-22.10 Sep 21, 2022
@ChuckHastings ChuckHastings deleted the update_louvain_c_api branch December 2, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants