Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that minimum required CMake version is now 3.23.1 #2725

Merged

Conversation

robertmaynard
Copy link
Contributor

With rapids-cmake now requiring CMake 3.23.1 update consumers to correctly express this requirement

@robertmaynard robertmaynard requested review from a team as code owners September 23, 2022 18:09
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@238f909). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10    #2725   +/-   ##
===============================================
  Coverage                ?   60.04%           
===============================================
  Files                   ?      111           
  Lines                   ?     6184           
  Branches                ?        0           
===============================================
  Hits                    ?     3713           
  Misses                  ?     2471           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BradReesWork BradReesWork added this to the 22.10 milestone Sep 29, 2022
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 29, 2022
With rapids-cmake now requiring CMake 3.23.1 update consumers
to correctly express this requirement
@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 26d47ff into rapidsai:branch-22.10 Oct 3, 2022
@robertmaynard robertmaynard deleted the update_cmake_version branch October 3, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants