Refactor k-core #2731
Refactor k-core #2731
Conversation
… user deletes the original but needs to recreate
…into fea_k_core_api
BradReesWork
added
improvement
| @@ -95,6 +95,13 @@ def ego_graph(G, n, radius=1, center=True, undirected=None, distance=None): | |||
|
|
|||
| result_graph = type(G)(directed=G.is_directed()) | |||
|
|
|||
| if not G.edgelist.weights: | |||
There was a problem hiding this comment.
C++ egonet does not require weights. Not sure we should require that in python.
There was a problem hiding this comment.
I get a segmentation fault when running the CAPI tests without weights
| @@ -110,6 +111,15 @@ def ego_graph(input_graph, n, radius=1, center=True): | |||
| # Initialize dask client | |||
| client = input_graph._client | |||
|
|
|||
| # FIXME: Implement a better way to check if the graph is weighted similar | |||
| # to 'simpleGraph' | |||
| if len(input_graph.edgelist.edgelist_df.columns) != 3: | |||
There was a problem hiding this comment.
C++ egonet does not require weights. Not sure we should require that in python.
There was a problem hiding this comment.
I get a segmentation fault when running the CAPI tests without weights
python/cugraph/cugraph/experimental/link_prediction/sorensen.py
Outdated
Show resolved
Hide resolved
ChuckHastings
added
3 - Ready for Review
and removed
Blocked
| @@ -146,13 +146,16 @@ def jaccard(input_graph, vertex_pair=None, use_weight=False): | |||
|
|
|||
| if use_weight: | |||
| raise ValueError( | |||
| "'use_weight' is currently not supported and must be set to 'False'" | |||
| "'use_weight' is currently not supported but will " "be in the next release" | |||
There was a problem hiding this comment.
I would just say it's not supported and remove the "in the next release" part. I'm thinking schedule-related messaging should go in a blog or release note type of document.
python/cugraph/cugraph/structure/graph_implementation/simpleDistributedGraph.py
Show resolved
Hide resolved
| array containing the vertex identifiers, the first and second items are device | ||
| arrays containing respectively the hubs and authorities values for the corresponding | ||
| vertices | ||
| A tuple of device arrays containing the sources and destinations with |
There was a problem hiding this comment.
Vertex pairs are not necessarily source & destinations.
|
@gpucibot merge |
This PR refactors
k-coreby leveraging the CAPI and updates the python cugraph tests. An MG implementation of k-core is also included in this PRcloses #2689
closes #2634
closes #2637
closes #2638