Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds .git-blame-ignore-revs for recent .py files reformatting by black #2809

Conversation

rlratzel
Copy link
Contributor

closes #2808

  • Adds .git-blame-ignore-revs for recent .py files reformatting by black
  • Minor change to improve an exception message, realized after seeing this log.

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 14, 2022
@rlratzel rlratzel added this to the 22.12 milestone Oct 14, 2022
@rlratzel rlratzel requested a review from eriknw October 14, 2022 03:05
@rlratzel rlratzel self-assigned this Oct 14, 2022
@rlratzel rlratzel requested a review from a team as a code owner October 14, 2022 03:05
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@4278e5c). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.12    #2809   +/-   ##
===============================================
  Coverage                ?   60.44%           
===============================================
  Files                   ?      111           
  Lines                   ?     6515           
  Branches                ?        0           
===============================================
  Hits                    ?     3938           
  Misses                  ?     2577           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rlratzel
Copy link
Contributor Author

rlratzel commented Oct 14, 2022

rerun tests

This issue is in place for the test failure I'm rerunning for, but rerunning for now since the failure is unrelated to this PR and may allow it to be merged until the issue is resolved.

@rlratzel
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5f40547 into rapidsai:branch-22.12 Oct 14, 2022
@rlratzel rlratzel deleted the branch-22.12-git_blame_file_and_tech_debt branch September 28, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .git-blame-ignore-revs file to ignore changes from initial black reformatting
4 participants