Adds better reporting of server subprocess errors during testing #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art so it fails faster, including the stdout/stderr output in the exception raised or to console depending on how it exited.
rlratzel
added
improvement
|
rerun tests reason: checking if new nightly builds of conda dependencies resolves solver issue. |
|
rerun tests reason: merged #3066 which should fix CI errors |
BradReesWork
approved these changes
Dec 16, 2022
|
rerun tests |
VibhuJawa
approved these changes
Dec 16, 2022
5 tasks
…2-cugraph_service_test_error_output
…2-cugraph_service_test_error_output
…2-cugraph_service_test_error_output
…2-cugraph_service_test_error_output
Codecov ReportBase: 58.50% // Head: 57.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #3012 +/- ##
================================================
- Coverage 58.50% 57.17% -1.33%
================================================
Files 133 148 +15
Lines 7895 9299 +1404
================================================
+ Hits 4619 5317 +698
- Misses 3276 3982 +706
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…2-cugraph_service_test_error_output
…2-cugraph_service_test_error_output
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 12, 2023
Users Vertex ID offsets in `CuGraphStore`. Offers the option of using pre-computed offsets by setting `renumber_graph=False`. Default behavior is to warn the user that it is computing offsets and save the original vertex ids in a new column. If `renumber_graph=True`, there is no warning, `renumber_vertices_by_type()` is called, and the vertex ids are overwritten. Due to a bug in `MGPropertyGraph`, if vertices are renumbered, edges must also be renumbered. Closes rapidsai/graph_dl#95 Closes #3069 - [x] Update Remote Graph tests - [x] Update CGS e2e tests - [x] Update SG PyG Extension Tests - [x] Update MG PyG Extension Tests - [x] Verify tests that are currently broken in CI Includes fix for #3069 Merge after #3012 Authors: - Alex Barghi (https://github.com/alexbarghi-nv) - Erik Welch (https://github.com/eriknw) - Rick Ratzel (https://github.com/rlratzel) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Rick Ratzel (https://github.com/rlratzel) - Vibhu Jawa (https://github.com/VibhuJawa) URL: #2996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3011
This PR adds a check for the server subprocess exitcode while waiting for it to start so it fails faster. Since it can fail faster, it also increases the wait to a full 60 seconds, which has shown to be helpful when starting a MG server that connects to a dask cluster.
It also includes the subprocess stdout/stderr output in the exception raised or to the console depending on how it exited to help debug why the server didn't start or crashed.