Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] cugraph_dgl benchmarks #3092

Merged
merged 16 commits into from
Jan 5, 2023
Merged

[REVIEW] cugraph_dgl benchmarks #3092

merged 16 commits into from
Jan 5, 2023

Conversation

VibhuJawa
Copy link
Member

@VibhuJawa VibhuJawa commented Dec 20, 2022 •
edited
Loading

This PR is a replacement of #3078 . Needed a new PR to avoid a bunch of conflict resolution.

Example command:

DASK_NUM_WORKERS=8 pytest bench_cugraph_dgl_uniform_neighbor_sample.py -k "MG and fanout_10_25 and rmat_26_8" gi--benchmark-save='8_rmat_26_8.json'

@VibhuJawa VibhuJawa requested a review from a team as a code owner December 20, 2022 21:21
@VibhuJawa VibhuJawa added feature request New feature or request non-breaking Non-breaking change labels Dec 20, 2022
@VibhuJawa VibhuJawa changed the title [WIP] cugraph_dgl benchmarks [REVIEW] cugraph_dgl benchmarks Dec 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022 •
edited
Loading

Codecov Report

Base: 57.14% // Head: 57.12% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (4a2ba8c) compared to base (1cb20d1).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff                @@
##           branch-23.02    #3092      +/-   ##
================================================
- Coverage         57.14%   57.12%   -0.03%     
================================================
  Files               148      148              
  Lines              9302     9302              
================================================
- Hits               5316     5314       -2     
- Misses             3986     3988       +2
Impacted Files Coverage Δ
...ython/cugraph/cugraph/community/ktruss_subgraph.py 85.29% <0.00%> (-5.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VibhuJawa
Copy link
Member Author

rerun tests

rlratzel
rlratzel approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I did have one minor suggestion.

benchmarks/cugraph-dgl/pytest-based/bench_cugraph_dgl_uniform_neighbor_sample.py Outdated Show resolved Hide resolved
@VibhuJawa
Copy link
Member Author

@rlratzel , All changes have been addressed , please feel free to merge.

@rlratzel
Copy link
Contributor

rlratzel commented Jan 3, 2023

@gpucibot merge

@VibhuJawa
Copy link
Member Author

VibhuJawa commented Jan 4, 2023 •
edited
Loading

rerun tests

Failure Reason: FAILED: 1 or more tests in cugraph-service

@VibhuJawa
Copy link
Member Author

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@VibhuJawa VibhuJawa requested a review from a team as a code owner January 4, 2023 19:37
@VibhuJawa
Copy link
Member Author

/merge

@VibhuJawa
Copy link
Member Author

/merge

@ajschmidt8
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit e40409d into rapidsai:branch-23.02 Jan 5, 2023
@ajschmidt8
Copy link
Member

The @gpucibot merge commands on this PR are no longer valid now that we've switched to /merge.

But /merge can only be used by RAPIDS org members with write permissions or greater in a given repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VibhuJawa @codecov-commenter @rlratzel @BradReesWork @ajschmidt8