[REVIEW] Remove dead-code from cugraph-dgl #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VibhuJawa
commented
Feb 16, 2023
| use_ddp, | ||
| ddp_seed, | ||
| shuffle, | ||
| kwargs.get("persistent_workers", False), |
There was a problem hiding this comment.
Unrelated to PR, helps to align with dgl-1.0 as that added a breaking change
| @@ -71,7 +71,7 @@ def set_input_directory(self, input_directory): | |||
| self._sampled_files = os.listdir(input_directory) | |||
| self._batch_to_fn_d = { | |||
| i: get_batch_fn_batch_start(i, self._sampled_files) | |||
| for i in range(0, self.num_batches + 1) | |||
| for i in range(0, self.num_batches) | |||
There was a problem hiding this comment.
Unrelated to PR, Caught likely now after updating #3249
| @@ -133,7 +133,7 @@ def set_input_directory(self, input_directory): | |||
| self._sampled_files = os.listdir(input_directory) | |||
| self._batch_to_fn_d = { | |||
| i: get_batch_fn_batch_start(i, self._sampled_files) | |||
| for i in range(0, self.num_batches + 1) | |||
| for i in range(0, self.num_batches) | |||
There was a problem hiding this comment.
Unrelated to PR, Caught likely now after updating #3249
VibhuJawa
added
non-breaking
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR closes #3290