Build wheels using new single image workflow #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
improvement
raydouglass
approved these changes
May 3, 2023
|
/merge |
|
@vyasr thank you for these updates. Can you also update the description to include at least an executive summary (or link to it elsewhere) to what the single image workflow is? I didn't feel like I had enough background to properly review. |
|
@rlratzel updated. But agreed, I think there's a lot to unpack here and not enough context for someone without background. I am happy to walk you through more of the workflow if you like so that you can see how things are working under the hood now. |
rapids-bot bot
pushed a commit
that referenced
this pull request
May 10, 2023
The build workflow was not updated along with the pr workflow in #3525 Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Ray Douglass (https://github.com/raydouglass) - Rick Ratzel (https://github.com/rlratzel) URL: #3547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now wheel builds have been using a two-pass, Docker-in-Docker approach that involves having one container run cibuildwheel, which in turn launches a manylinux container in which the build occurs. This approach is cumbersome to work with and makes it difficult to create local builds that match CI exactly. This PR updates to using the new single-image workflow in rapidsai/shared-workflows#71 that uses a new set of Docker images built just for RAPIDS and eschews cibuildwheel in favor of launching
pip wheeldirectly. This approach should be far easier to make maintain and make work locally. It also removes our dependence on modifying upstream pypa manylinux images, which is fairly difficult to maintain.