[BUG] Fix Incorrect File Selection in cuGraph-PyG Loader #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BradReesWork
approved these changes
May 24, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the cuGraph-PyG loader does not properly handle the case where samples were previously computed and saved to disk. It also compares the batch ids to determine when it is done processing, which is also incorrect, since batches can be loaded in any order.
This PR updates the cuGraph-PyG loader to use only the list of input files to determine when it is done. It also allows specifying the input file list to support cases where previously-computed batches are loaded from disk. The loader tests are updated to verify the new behavior and ensure that loading previously-computed batches works as expected.