-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add Pure DGL Dataloading benchmark #3660
[REVIEW] Add Pure DGL Dataloading benchmark #3660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I would like to get a look from @tingyu66 here too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. If being nitpicking, I'd like to fix random seed (with dgl.seed()
and torch.manual_seed()
) for all benchmarks.
@tingyu66 , Added seed with commit: f99a518 @alexbarghi-nv , I think we should be good to merge. |
Just dropping updated numbers for awareness as we use this in comparisons.
|
/ok to test |
/ok to test |
/okay to test |
/merge |
This PR adds the DGL data loading benchmark:
Arguments supported:
This produces the following results on a V100: