Promote `Datasets` to stable and clean-up unit tests #3712

nv-rliu · 2023-07-17T20:38:40Z

Addresses #3675 and #3706

This PR moves the datasets API from experimental to stable. Users can now do:

from cugraph.datasets import karate

G = karate.get_graph()

The existing experimental.datasets package has been updated with the promoted_experimental_warning_wrapper(). All notebooks, docstrings, and unit test dependencies on datasets have been updated to use the stable API.

This PR also removes the networkx warning suppression from the unit tests.

Promote datasets

…e using soon-to-be deleted karate variants from datasets API

…u/cugraph into stable-datasets-notebooks

Merge changes to Notebooks and Docstrings

This reverts commit 0e7e881.

Update concurrent_unordered_map.cuh to include hash_functions.cuh from cudf/hashing/detail

…on due to filenames originally having hyphens

…s unit test

rlratzel

Getting close! I like the new tests to verify the meta-data. Those will be especially useful if we add new datasets. I mainly had a few issues with the new descriptions.

python/cugraph/cugraph/datasets/metadata/dolphins.yaml

python/cugraph/cugraph/datasets/metadata/email_Eu_core.yaml

python/cugraph/cugraph/datasets/metadata/karate_asymmetric.yaml

python/cugraph/cugraph/datasets/metadata/karate_disjoint.yaml

python/cugraph/cugraph/datasets/metadata/small_line.yaml

python/cugraph/cugraph/datasets/metadata/small_tree.yaml

python/cugraph/cugraph/datasets/metadata/toy_graph.yaml

python/cugraph/cugraph/datasets/metadata/toy_graph_undirected.yaml

…ty.py

ajschmidt8

Approving ops-codeowner file changes

rlratzel · 2023-07-28T04:43:01Z

/merge

This PR fixes the `build.yaml` workflow. The `node_type` reusable workflow input was placed incorrectly in #3712. Skipping CI since this file isn't tested in PRs. [skip ci]

Ralph Liu and others added 30 commits June 29, 2023 07:32

Create stable datasets api from experimental

c65f906

add promoted_experimental_warning_wrapper to dataset

5dbca14

pre-commit style fix

4182d2e

Merge pull request #2 from nv-rliu/promote-datasets

687db8e

Promote datasets

Update notebooks to use stable datasets api

a5348a1

Update docstrings to use stable datasets api

01d4e7b

Update unit tests to use stable datasets API

7157cb7

Removed variants of the Karate dataset

1ec0ef8

Moving dataset batches into testing/utils.py

0f9aa09

Expand test_dataset.py unit test coverage

965ec22

Correcting YAML file inconsistencies

c1281aa

Update unit tests to use migrated dataset batches. Flag tests that ar…

cc3973d

…e using soon-to-be deleted karate variants from datasets API

Merge branch 'rapidsai:branch-23.08' into branch-23.08

1f3184b

Merge branch 'rapidsai:branch-23.08' into branch-23.08

543b770

Merge branch 'rapidsai:branch-23.08' into branch-23.08

bc27113

Removed outdated dataset batches from unit tests

15a00f9

Merge branch 'rapidsai:branch-23.08' into stable-datasets-notebooks

b5d7ae0

Merge branch 'branch-23.08' into stable-datasets-notebooks

aa25d8a

Merge branch 'stable-datasets-notebooks' of https://github.com/nv-rli…

52cec16

…u/cugraph into stable-datasets-notebooks

Merge pull request #3 from nv-rliu/stable-datasets-notebooks

2c55538

Merge changes to Notebooks and Docstrings

empty commit to re-run CI notebook checks

a7c5d1f

refactored remaining tests using experimental datasets

8309ce1

fix failing notebook

552fa2b

Update dataset batch naming scheme. update unit tests.

294166c

remove warnings import before nx

0e7e881

Revert "remove warnings import before nx"

3b47cdf

This reverts commit 0e7e881.

Update concurrent_unordered_map.cuh

60bc725

Update concurrent_unordered_map.cuh to include hash_functions.cuh from cudf/hashing/detail

Fix include path for default_has

8119705

Fix include path for default_hash and hash_functions

f182366

test_dataset.py verifies experimental DeprecationWarnings

128cadc

Ralph Liu and others added 8 commits July 25, 2023 14:05

Update notebooks: 'fetch' -> 'download'

4cfca07

Update naming scheme with all underscores

336f57c

Unable to change 'name' field to adhere to underscore naming conventi…

b89b363

…on due to filenames originally having hyphens

Merge branch 'branch-23.08' into remove-nx-suppression-warnings

1e7cb63

Update Sorensen notebook to use stable

c519590

Fix bulk sampling style

958af97

Remove ktruss_polbooks from cugraph.datasets and refactor test_k_trus…

fb9e75e

…s unit test

Add unit test to check for graph symmetry and update metadata YAML files

f173e13

nv-rliu removed the non-breaking Non-breaking change label Jul 26, 2023

rlratzel requested changes Jul 27, 2023

View reviewed changes

rlratzel added the non-breaking Non-breaking change label Jul 27, 2023

Ralph Liu and others added 3 commits July 26, 2023 19:40

Update metadata files based on feedback from @rlratzel

87dd183

Merge branch 'branch-23.08' into remove-nx-suppression-warnings

c699844

Update github workflow pr.yaml and build.yaml

e4754c6

nv-rliu requested a review from a team as a code owner July 27, 2023 15:48

Add missing netscience import to test_batch_edge_betweenness_centrali…

05182ef

…ty.py

ajschmidt8 mentioned this pull request Jul 27, 2023

Update build.yaml #3751

Closed

ajschmidt8 approved these changes Jul 27, 2023

View reviewed changes

Ralph Liu and others added 2 commits July 27, 2023 12:30

Fix YAML file formatting issue

1fa0496

Merge branch 'rapidsai:branch-23.08' into remove-nx-suppression-warnings

77d0cd3

rlratzel approved these changes Jul 28, 2023

View reviewed changes

rlratzel removed the request for review from a team July 28, 2023 04:42

rapids-bot bot merged commit 836c27a into rapidsai:branch-23.08 Jul 28, 2023
54 checks passed

ajschmidt8 mentioned this pull request Jul 28, 2023

Fix build.yaml workflow #3756

Merged

rapids-bot bot pushed a commit that referenced this pull request Jul 28, 2023

Fix build.yaml workflow

52446e3

This PR fixes the `build.yaml` workflow. The `node_type` reusable workflow input was placed incorrectly in #3712. Skipping CI since this file isn't tested in PRs. [skip ci]

ajschmidt8 added a commit that referenced this pull request Jul 28, 2023

Fix build.yaml workflow (#3756)

9a60e51

This PR fixes the `build.yaml` workflow. The `node_type` reusable workflow input was placed incorrectly in #3712. Skipping CI since this file isn't tested in PRs. [skip ci]

rlratzel mentioned this pull request Jul 30, 2023

[ENH] Move datasets API from experimental to stable #3675

Closed

nv-rliu mentioned this pull request Jul 31, 2023

[FEA]: Remove NX Deprecation Warning Suppression #3706

Closed

nv-rliu deleted the remove-nx-suppression-warnings branch July 31, 2023 13:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promote `Datasets` to stable and clean-up unit tests #3712

Promote `Datasets` to stable and clean-up unit tests #3712

nv-rliu commented Jul 17, 2023 •

edited

Loading

rlratzel left a comment

ajschmidt8 left a comment

rlratzel commented Jul 28, 2023

Promote Datasets to stable and clean-up unit tests #3712

Promote Datasets to stable and clean-up unit tests #3712

Conversation

nv-rliu commented Jul 17, 2023 • edited Loading

rlratzel left a comment

Choose a reason for hiding this comment

ajschmidt8 left a comment

Choose a reason for hiding this comment

rlratzel commented Jul 28, 2023

Promote `Datasets` to stable and clean-up unit tests #3712

Promote `Datasets` to stable and clean-up unit tests #3712

nv-rliu commented Jul 17, 2023 •

edited

Loading