Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Cugraph dgl block improvements #3810

Merged
merged 12 commits into from
Aug 22, 2023
Merged

[REVIEW] Cugraph dgl block improvements #3810

merged 12 commits into from
Aug 22, 2023

Conversation

VibhuJawa
Copy link
Member

@VibhuJawa VibhuJawa commented Aug 17, 2023 •
edited
Loading

This PR fixes: #3784 and speeds up MFG creation by 3.5x .

Todo:

  • Add tests

Benchmarked on 6_462_743_488 edges with a batch size of 128 on a 1 V100:

Before PR Times:

1min 17s

After PR Times:

22 s

See link: https://gist.github.com/VibhuJawa/4852203f2e96de09d84d698af945682d

Profiling:

After PR: #3810

image image

Profile of splitting df into tensors :

image

@VibhuJawa VibhuJawa requested a review from a team as a code owner August 17, 2023 22:28
@VibhuJawa VibhuJawa mentioned this pull request Aug 18, 2023
Closed
@VibhuJawa VibhuJawa added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Aug 18, 2023
@VibhuJawa VibhuJawa self-assigned this Aug 18, 2023
@VibhuJawa VibhuJawa marked this pull request as draft August 18, 2023 00:21
@VibhuJawa VibhuJawa marked this pull request as ready for review August 21, 2023 00:30
@VibhuJawa VibhuJawa changed the title [WIP] Cugraph dgl block improvements [REVIEW] Cugraph dgl block improvements Aug 21, 2023
alexbarghi-nv
alexbarghi-nv approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@VibhuJawa
Copy link
Member Author

@tingyu66 , Could you take another look please before we try to get this in.

tingyu66
tingyu66 requested changes Aug 22, 2023
View reviewed changes
Copy link
Member

@tingyu66 tingyu66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments. Looks good otherwise.

python/cugraph-dgl/tests/test_dataset.py Outdated Show resolved Hide resolved
python/cugraph-dgl/tests/test_utils.py Outdated Show resolved Hide resolved
@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit f0d16c1 into rapidsai:branch-23.10 Aug 22, 2023
54 checks passed
@VibhuJawa VibhuJawa mentioned this pull request Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarghi-nv alexbarghi-nv alexbarghi-nv approved these changes

@tingyu66 tingyu66 tingyu66 approved these changes

Assignees

@VibhuJawa VibhuJawa

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PERF] Speedup splitting dataframe into tensors splitted by batch_id , hop_id
3 participants
@VibhuJawa @alexbarghi-nv @tingyu66