Remove the assumption made on the client data's keys #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
|
/ok to test |
|
/ok to test |
alexbarghi-nv
approved these changes
Sep 7, 2023
|
/merge |
|
/merge |
|
/ok to test |
|
/merge |
rlratzel
pushed a commit
to rlratzel/cugraph
that referenced
this pull request
Sep 8, 2023
When calling `client.has_what(`) which returns the data's key that are held in each worker’s memory, those keys used to be returned as string but a recent change in `dask` changed the type to tuples
From `{worker_ip_address: ("('from-delayed-190587f1b2318dc54d5f92a79e59b71a', 0)", "('from-delayed-190587f1b2318dc54d5f92a79e59b71a', 1)")}` to`{worker_ip_address: (('from-delayed-c3d92b2cc9948634e82a0b2b62453a6c', 0), ('from-delayed-c3d92b2cc9948634e82a0b2b62453a6c', 1))}`
When mapping workers to persisted data in the function `get_persisted_df_worker_map`, an assumption about the type of those keys was made thereby breaking our MG tests.
This PR removes that assumption.
Closes rapidsai#3834
Authors:
- Joseph Nke (https://github.com/jnke2016)
- Alex Barghi (https://github.com/alexbarghi-nv)
Approvers:
- Alex Barghi (https://github.com/alexbarghi-nv)
URL: rapidsai#3835
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
client.has_what() which returns the data's key that are held in each worker’s memory, those keys used to be returned as string but a recent change indaskchanged the type to tuplesFrom
{worker_ip_address: ("('from-delayed-190587f1b2318dc54d5f92a79e59b71a', 0)", "('from-delayed-190587f1b2318dc54d5f92a79e59b71a', 1)")}to{worker_ip_address: (('from-delayed-c3d92b2cc9948634e82a0b2b62453a6c', 0), ('from-delayed-c3d92b2cc9948634e82a0b2b62453a6c', 1))}When mapping workers to persisted data in the function
get_persisted_df_worker_map, an assumption about the type of those keys was made thereby breaking our MG tests.This PR removes that assumption.
Closes #3834