nx-cugraph: handle louvain with isolated nodes #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlratzel
reviewed
Sep 28, 2023
| "louvain_communities", | ||
| # END: functions | ||
| }, | ||
| "extra_docstrings": { | ||
| # BEGIN: extra_docstrings | ||
| "betweenness_centrality": "`weight` parameter is not yet supported.", | ||
| "edge_betweenness_centrality": "`weight` parameter is not yet supported.", | ||
| "louvain_communities": "`threshold` and `seed` parameters are currently ignored.", | ||
| "louvain_communities": "`seed` parameter is currently ignored.", |
There was a problem hiding this comment.
Do we need to add something in the docs about max_level being capped at 500?
There was a problem hiding this comment.
Added (max: 500) to the max_level parameter doc.
rlratzel
added
improvement
rlratzel
approved these changes
Sep 29, 2023
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
Fixes #3963 and add `connected_components`, `is_connected`, `node_connected_component`, and `number_connected_components`. Also updated `_groupby` to handle groups that are not consecutive integers starting with 0. Also, `plc.weakly_connected_components` does not handle isolated nodes well, and I needed to handle this at the Python layer as was done in #3897 Authors: - Erik Welch (https://github.com/eriknw) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: #3965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles isolated nodes in
louvain_communitiessimilar to what is done in #3886. This is expected to be a temporary fix until pylibcugraph can handle isolated nodes.As a bonus, I added
isolatesalgorithm 🎉CC @naimnv @rlratzel