Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix Graph Construction From Pandas in cuGraph-PyG #3985

Merged

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Nov 7, 2023

The current graph construction creates a single pandas dataframe, which for larger datasets (i.e. ogbn-papers100M) cannot be serialized. This PR resolves this by breaking up the dataframe into scattered numpy arrays that are then reassembled.

Merge after #3978

@alexbarghi-nv alexbarghi-nv added bug Something isn't working CRITICAL BUG! BUG that needs to be FIX NOW !!!! labels Nov 7, 2023
@alexbarghi-nv alexbarghi-nv self-assigned this Nov 7, 2023
@alexbarghi-nv alexbarghi-nv requested review from a team as code owners November 7, 2023 17:03
@alexbarghi-nv alexbarghi-nv marked this pull request as draft November 7, 2023 17:03
@alexbarghi-nv alexbarghi-nv added this to the 23.12 milestone Nov 7, 2023
@alexbarghi-nv alexbarghi-nv added the non-breaking Non-breaking change label Nov 7, 2023
@alexbarghi-nv alexbarghi-nv added DO NOT MERGE Hold off on merging; see PR for details Blocked Cannot progress due to external reasons and removed DO NOT MERGE Hold off on merging; see PR for details labels Nov 7, 2023
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review November 7, 2023 19:09
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the dask changes and they look good to me, will review other bits after the

#3978 is merged in

Copy link

copy-pr-bot bot commented Nov 12, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@alexbarghi-nv
Copy link
Member Author

/ok to test

@alexbarghi-nv
Copy link
Member Author

/ok to test

@alexbarghi-nv
Copy link
Member Author

/ok to test

@alexbarghi-nv alexbarghi-nv removed the request for review from a team November 17, 2023 14:20
@alexbarghi-nv alexbarghi-nv removed the Blocked Cannot progress due to external reasons label Nov 17, 2023
@alexbarghi-nv
Copy link
Member Author

/ok to test

@alexbarghi-nv
Copy link
Member Author

/ok to test

@alexbarghi-nv
Copy link
Member Author

/ok to test

Copy link
Member

@tingyu66 tingyu66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only have a minor question.

@alexbarghi-nv
Copy link
Member Author

/ok to test

@alexbarghi-nv
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 0f28b2e into rapidsai:branch-23.12 Nov 20, 2023
73 checks passed
rapids-bot bot pushed a commit that referenced this pull request Nov 20, 2023
Supports the `drop_last` argument in cuGraph-PyG for better compatibility with native PyG workflows.

Closes #3949 

Merge after #3985

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Naim (https://github.com/naimnv)

Approvers:
  - Tingyu Wang (https://github.com/tingyu66)
  - Brad Rees (https://github.com/BradReesWork)
  - Vibhu Jawa (https://github.com/VibhuJawa)

URL: #3995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CRITICAL BUG! BUG that needs to be FIX NOW !!!! non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants