Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address FIXMEs #3988

Merged
merged 11 commits into from
Nov 20, 2023
Merged

Address FIXMEs #3988

merged 11 commits into from
Nov 20, 2023

Conversation

seunghwak
Copy link
Contributor

This PR works on addressing FIXMEs (and reduce the number of outstanding FIXMEs).

@seunghwak seunghwak added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 8, 2023
@seunghwak seunghwak added this to the 23.12 milestone Nov 8, 2023
@seunghwak seunghwak self-assigned this Nov 8, 2023
@seunghwak seunghwak changed the title [WIP] Address FIXMEs Address FIXMEs Nov 15, 2023
@seunghwak seunghwak marked this pull request as ready for review November 15, 2023 01:36
@seunghwak seunghwak requested a review from a team as a code owner November 15, 2023 01:36
Copy link
Contributor

@naimnv naimnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naimnv
Copy link
Contributor

naimnv commented Nov 18, 2023

/ok to test

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit d34e3d6 into rapidsai:branch-23.12 Nov 20, 2023
73 checks passed
@seunghwak seunghwak deleted the enh_address_fixmes branch May 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants