Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to scikit-build-core #4053

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Switch to scikit-build-core #4053

merged 5 commits into from
Dec 14, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 8, 2023 •
edited
Loading

Contributes to rapidsai/build-planning#2

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 8, 2023
@github-actions github-actions bot added the ci label Dec 8, 2023
@vyasr vyasr marked this pull request as ready for review December 12, 2023 23:19
@vyasr vyasr requested review from a team as code owners December 12, 2023 23:19
@vyasr vyasr added breaking Breaking change and removed non-breaking Non-breaking change labels Dec 12, 2023
@jarmak-nv jarmak-nv mentioned this pull request Dec 13, 2023
Closed
bdice
bdice approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one small fix suggestion.

build.sh Outdated Show resolved Hide resolved
@vyasr @bdice
Update build.sh
ee45ba6 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
rlratzel
rlratzel reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumped out so it LGTM. I do have a question about some FIXMEs though...

build.sh Show resolved Hide resolved
@vyasr vyasr requested a review from rlratzel December 14, 2023 17:26
rlratzel
rlratzel approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, it's great to be able to remove that FIXME special case, thanks!

@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit d7c88d1 into rapidsai:branch-24.02 Dec 14, 2023
74 checks passed
@vyasr vyasr deleted the feat/scikit_build_core branch December 14, 2023 23:31
@ChuckHastings ChuckHastings mentioned this pull request May 30, 2024
Merged
rapids-bot bot pushed a commit that referenced this pull request Jun 5, 2024
@ChuckHastings
Properly clean up python directories (#4453)
8f3250f 
#4053 changed the location of the build directory for python code, but the build.sh script was cleaning up the old location.

This PR updates the build script to address this.

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #4453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@bdice bdice bdice approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
breaking Breaking change ci CMake conda improvement Improvement / enhancement to an existing function python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @rlratzel @bdice @ajschmidt8