Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Experimental Wrappers from GNN Code #4070

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
)

from cugraph.structure.symmetrize import symmetrize
from cugraph.experimental.gnn import BulkSampler
from cugraph.gnn import BulkSampler

import cugraph

Expand Down
2 changes: 1 addition & 1 deletion python/cugraph-dgl/cugraph_dgl/dataloading/dataloader.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import cupy as cp
import cudf
from cugraph.utilities.utils import import_optional
from cugraph.experimental import BulkSampler
from cugraph.gnn import BulkSampler
from dask.distributed import default_client, Event
from cugraph_dgl.dataloading import (
HomogenousBulkSamplerDataset,
Expand Down
6 changes: 1 addition & 5 deletions python/cugraph-pyg/cugraph_pyg/data/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from cugraph.utilities.api_tools import experimental_warning_wrapper

from cugraph_pyg.data.cugraph_store import EXPERIMENTAL__CuGraphStore

CuGraphStore = experimental_warning_wrapper(EXPERIMENTAL__CuGraphStore)
from cugraph_pyg.data.cugraph_store import CuGraphStore
2 changes: 1 addition & 1 deletion python/cugraph-pyg/cugraph_pyg/data/cugraph_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ def cast(cls, *args, **kwargs):
return cls(*args, **kwargs)


class EXPERIMENTAL__CuGraphStore:
class CuGraphStore:
"""
Duck-typed version of PyG's GraphStore and FeatureStore.
"""
Expand Down
12 changes: 2 additions & 10 deletions python/cugraph-pyg/cugraph_pyg/loader/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from cugraph.utilities.api_tools import experimental_warning_wrapper
from cugraph_pyg.loader.cugraph_node_loader import CuGraphNeighborLoader

from cugraph_pyg.loader.cugraph_node_loader import EXPERIMENTAL__CuGraphNeighborLoader

CuGraphNeighborLoader = experimental_warning_wrapper(
EXPERIMENTAL__CuGraphNeighborLoader
)

from cugraph_pyg.loader.cugraph_node_loader import EXPERIMENTAL__BulkSampleLoader

BulkSampleLoader = experimental_warning_wrapper(EXPERIMENTAL__BulkSampleLoader)
from cugraph_pyg.loader.cugraph_node_loader import BulkSampleLoader
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import cupy
import cudf

from cugraph.experimental.gnn import BulkSampler
from cugraph.gnn import BulkSampler
from cugraph.utilities.utils import import_optional, MissingModule

from cugraph_pyg.data import CuGraphStore
Expand All @@ -42,7 +42,7 @@
)


class EXPERIMENTAL__BulkSampleLoader:
class BulkSampleLoader:

__ex_parquet_file = re.compile(r"batch=([0-9]+)\-([0-9]+)\.parquet")

Expand Down Expand Up @@ -478,7 +478,7 @@ def __iter__(self):
return self


class EXPERIMENTAL__CuGraphNeighborLoader:
class CuGraphNeighborLoader:
def __init__(
self,
data: Union[CuGraphStore, Tuple[CuGraphStore, CuGraphStore]],
Expand Down Expand Up @@ -527,7 +527,7 @@ def batch_size(self) -> int:
return self.__batch_size

def __iter__(self):
self.current_loader = EXPERIMENTAL__BulkSampleLoader(
self.current_loader = BulkSampleLoader(
self.__feature_store,
self.__graph_store,
self.__input_nodes,
Expand Down
4 changes: 2 additions & 2 deletions python/cugraph/cugraph/experimental/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@
experimental_warning_wrapper(EXPERIMENTAL__find_bicliques)
)

from cugraph.gnn.data_loading import EXPERIMENTAL__BulkSampler
from cugraph.gnn.data_loading import BulkSampler

BulkSampler = experimental_warning_wrapper(EXPERIMENTAL__BulkSampler)
BulkSampler = promoted_experimental_warning_wrapper(BulkSampler)


from cugraph.link_prediction.jaccard import jaccard, jaccard_coefficient
Expand Down
6 changes: 3 additions & 3 deletions python/cugraph/cugraph/experimental/gnn/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from cugraph.gnn.data_loading import EXPERIMENTAL__BulkSampler
from cugraph.utilities.api_tools import experimental_warning_wrapper
from cugraph.gnn.data_loading import BulkSampler
from cugraph.utilities.api_tools import promoted_experimental_warning_wrapper

BulkSampler = experimental_warning_wrapper(EXPERIMENTAL__BulkSampler)
BulkSampler = promoted_experimental_warning_wrapper(BulkSampler)
1 change: 1 addition & 0 deletions python/cugraph/cugraph/gnn/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@
# limitations under the License.

from .feature_storage.feat_storage import FeatureStore
from .data_loading.bulk_sampler import BulkSampler
2 changes: 1 addition & 1 deletion python/cugraph/cugraph/gnn/data_loading/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from cugraph.gnn.data_loading.bulk_sampler import EXPERIMENTAL__BulkSampler
from cugraph.gnn.data_loading.bulk_sampler import BulkSampler
4 changes: 2 additions & 2 deletions python/cugraph/cugraph/gnn/data_loading/bulk_sampler.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import time


class EXPERIMENTAL__BulkSampler:
class BulkSampler:
"""
Performs sampling based on input seeds grouped into batches by
a batch id. Writes the output minibatches to parquet, with
Expand Down Expand Up @@ -158,7 +158,7 @@ def add_batches(
Examples
--------
>>> import cudf
>>> from cugraph.experimental.gnn import BulkSampler
>>> from cugraph.gnn import BulkSampler
>>> from cugraph.datasets import karate
>>> import tempfile
>>> df = cudf.DataFrame({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import cupy
import cugraph
from cugraph.datasets import karate, email_Eu_core
from cugraph.experimental.gnn import BulkSampler
from cugraph.gnn import BulkSampler
from cugraph.utilities.utils import create_directory_with_overwrite

import os
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import cugraph
import dask_cudf
from cugraph.datasets import karate, email_Eu_core
from cugraph.experimental import BulkSampler
from cugraph.gnn import BulkSampler
from cugraph.utilities.utils import create_directory_with_overwrite


Expand Down