Support CUDA 12.2 #4088
Merged
Support CUDA 12.2 #4088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jameslamb
changed the title
jameslamb
changed the title
jameslamb
changed the title
jameslamb
changed the title
|
one C API test is failing on CUDA 12.2 (ubunut 22.04, amd64) |
jakirkham
added
feature request
3 tasks
ChuckHastings
approved these changes
Feb 12, 2024
|
Depends on PR: rapidsai/raft#2179 |
|
Retesting now that the aforementioned RAFT PR is merged and RAFT packages are available |
|
Still seeing old failure Trying to restart again |
jakirkham
reviewed
Feb 14, 2024
Comment on lines
272
to
274
| // This test is skipped due to a bug in cuSparse 12.2 that affects RAFT. | ||
| // See https://github.com/rapidsai/raft/issues/2186 | ||
| GTEST_SKIP(); |
ChuckHastings
approved these changes
Feb 14, 2024
Co-authored-by: jakirkham <jakirkham@gmail.com>
|
Looks like there failures in the devcontainers |
jakirkham
force-pushed
the
test-cuda-12.2
branch
from
98cb335
to
98ce676
Compare
jakirkham
force-pushed
the
test-cuda-12.2
branch
from
98ce676
to
87bb1a6
Compare
jakirkham
reviewed
Feb 14, 2024
Comment on lines
+740
to
+747
| ############################################################################# | ||
| # Skipping due to CUDA 12.2 failure that traces back to RAFT # | ||
| # TODO: Uncomment this once the issue is fixed. # | ||
| # # | ||
| # xref: https://github.com/rapidsai/cugraph/issues/4173 # | ||
| # xref: https://github.com/rapidsai/raft/issues/2186 # | ||
| ############################################################################# | ||
| # ConfigureCTest(CAPI_LEGACY_SPECTRAL_TEST c_api/legacy_spectral_test.c) |
There was a problem hiding this comment.
Had trouble getting the GTEST_SKIPs Bradley added to work. So just commenting this for now. We can uncomment in a new PR to test fixes
xref: #4173
xref: rapidsai/raft#2186
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
Follow-up to #4088 For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows` with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged. ### Notes for Reviewers This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS. For more details see: * rapidsai/build-planning#7 *(created with `rapids-reviser`)* Authors: - James Lamb (https://github.com/jameslamb) - https://github.com/jakirkham Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #4175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes for Reviewers
This is part of ongoing work to build and test packages against CUDA 12.2.2 across all of RAPIDS.
For more details see:
Planning a second round of PRs to revert these references back to a proper
branch-24.{nn}release branch ofshared-workflowsonce rapidsai/shared-workflows#166 is merged.(created with
rapids-reviser)