Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and Fix test_induced_subgraph_mg #4183

Merged

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Feb 20, 2024

Addresses #459

Changes:

  • Updates cugraph/community/induced_subgraph.py to use Series.iloc to avoid a DeprecationWarning when calling the function
  • This PR fixes a bug in test_mg_induced_subgraph where it would break when passed an ndarray object while trying to construct an MG induced sub-graph.
  • This unit test has been cleaned up to use the cugraph.datasets API to construct SG and MG graph objects, as well as the sample_random_vertices function to construct sub-graphs the proper way.

Notes:

  • The offsets parameter is not ready for testing yet.
  • There is no one-hop neighbor check in place to verify if the sub-graphs are actually generated correctly.
  • This test will be updated once those are available.

@nv-rliu nv-rliu requested a review from a team as a code owner February 20, 2024 20:38
@nv-rliu nv-rliu added the ? - Needs Triage Need team to review and classify label Feb 20, 2024
@nv-rliu nv-rliu added bug Something isn't working breaking Breaking change and removed ? - Needs Triage Need team to review and classify labels Feb 21, 2024
@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit c61f1f9 into rapidsai:branch-24.04 Feb 21, 2024
109 checks passed
@nv-rliu nv-rliu deleted the b2404-fix-induced-subgraph-mg branch February 21, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants