Enable edge masking in the remaining primitives #4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fea_prim_edge_masking
…to fea_prim_edge_masking
…to fea_prim_edge_masking
…to fea_prim_edge_masking
…to fea_prim_edge_masking
…to fea_prim_edge_masking
…to fea_more_prim_edge_masking
ChuckHastings
approved these changes
Mar 9, 2024
| using Tests_MGPerVTransformReduceDstKeyAggregatedOutgoingE_Rmat = | ||
| Tests_MGPerVTransformReduceDstKeyAggregatedOutgoingE<cugraph::test::Rmat_Usecase>; | ||
|
|
||
| #if 0 |
There was a problem hiding this comment.
Is there a reason these are skipped? Should we document that reason, eliminate the skipping, or eliminate the code?
There was a problem hiding this comment.
Yes, cugraph::kv_store_t does not compile with cuco mode and thrust tuple type value. I am planning to fix this in a separate PR but I will also add a FIXME here.
naimnv
approved these changes
Mar 9, 2024
jnke2016
approved these changes
Mar 10, 2024
…to fea_more_prim_edge_masking
…to fea_more_prim_edge_masking
|
/merge |
rapids-bot
bot
merged commit 120e5b8
into
rapidsai:branch-24.04
145 of 146 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will update all the remaining primitives to support edge masking.
This PR pulls updates from #4126 and better be reviewed/merged after PR #4126.