Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional kwargs to GATConv #4210

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

tingyu66
Copy link
Member

@tingyu66 tingyu66 commented Mar 4, 2024

Support deterministic/high-precision flags in mha primitives, introduced in https://github.com/rapidsai/cugraph-ops/pull/607

@tingyu66 tingyu66 requested a review from a team as a code owner March 4, 2024 16:01
@github-actions github-actions bot added the python label Mar 4, 2024
@tingyu66 tingyu66 requested a review from stadlmax March 4, 2024 17:33
@tingyu66 tingyu66 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 4, 2024
@tingyu66 tingyu66 changed the title Add additional **kwargs to GATConv Add additional kwargs to GATConv Mar 4, 2024
Copy link
Contributor

@stadlmax stadlmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tingyu66 tingyu66 self-assigned this Mar 6, 2024
@stadlmax
Copy link
Contributor

stadlmax commented Mar 8, 2024

@tingyu66 Since we might run into gray areas of the benchmark by only passing kwargs, can you explicitly include all flags in the API?

Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 6c4f881 into rapidsai:branch-24.04 Mar 11, 2024
145 checks passed
@tingyu66 tingyu66 deleted the gatconv-deterministic-args branch March 11, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants