Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bug in MG ego_graph #4262

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Fix Bug in MG ego_graph #4262

merged 4 commits into from
Mar 26, 2024

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Mar 20, 2024

Closes #4190
cc: @jnke2016

This PR adds a function to comms.py which returns a mapping of workers to ranks. This is then sorted in part_utils.py before being used to submit jobs to dask.

This should fix a bug in MG ego_graph where induced subgraphs were being returned in seemingly random orders (while the results are correct).

@nv-rliu nv-rliu requested review from a team as code owners March 20, 2024 19:31
@nv-rliu nv-rliu added non-breaking Non-breaking change cuGraph bug Something isn't working labels Mar 20, 2024
jnke2016
jnke2016 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@jnke2016 jnke2016 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great job on tracking and resolving the egoGraph bug.

acostadon
acostadon approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@nv-rliu nv-rliu requested review from jnke2016 and a team March 21, 2024 00:14
acostadon
acostadon approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@github-actions github-actions bot added the conda label Mar 21, 2024
@nv-rliu nv-rliu changed the base branch from branch-24.04 to branch-24.06 March 25, 2024 14:45
@github-actions github-actions bot removed the conda label Mar 25, 2024
@rlratzel rlratzel removed the request for review from a team March 25, 2024 15:54
@rlratzel
Copy link
Contributor

I removed ops-codeowners from the review list since the current set of files in the PR aren't relevant to ops.

@nv-rliu nv-rliu added this to the 24.06 milestone Mar 25, 2024
@github-actions github-actions bot added the ci label Mar 25, 2024
@ChuckHastings
Copy link
Collaborator

/merge

1 similar comment
@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit a9d6c0d into rapidsai:branch-24.06 Mar 26, 2024
131 checks passed
@nv-rliu nv-rliu deleted the fix-mg-ego-python branch March 26, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@raydouglass raydouglass raydouglass approved these changes

@jnke2016 jnke2016 jnke2016 approved these changes

@acostadon acostadon acostadon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ci non-breaking Non-breaking change python
Projects
None yet
Milestone
24.06
Development

Successfully merging this pull request may close these issues.

[BUG]: MG ego_graph Different from SG
7 participants
@nv-rliu @rlratzel @ChuckHastings @alexbarghi-nv @raydouglass @jnke2016 @acostadon