Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit hooks to include all C and C++ files #4332

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

ChuckHastings
Copy link
Collaborator

#3062 added pre-commit hooks for formatting C and C++ code. However, libcugraph_etl and the C API unit tests are currently excluded from that check. The intention was to get back around to them and include them in the testing. However, that slipped through the cracks.

This PR adds the pre-commit hooks for those files as well.

@ChuckHastings ChuckHastings self-assigned this Apr 9, 2024
@ChuckHastings ChuckHastings added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed cuGraph labels Apr 9, 2024
@ChuckHastings ChuckHastings added this to the 24.06 milestone Apr 9, 2024
@ChuckHastings ChuckHastings marked this pull request as ready for review April 9, 2024 21:11
@ChuckHastings ChuckHastings requested a review from a team as a code owner April 9, 2024 21:11
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ChuckHastings ChuckHastings changed the title Update pre-commit hooks to include all C++ files Update pre-commit hooks to include all C and C++ files Apr 10, 2024
@ChuckHastings
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit 70a3892 into rapidsai:branch-24.06 Apr 15, 2024
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants