Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused benchmark fixture in test_dask_mg_random_walks #4391

Merged
merged 4 commits into from
May 11, 2024
Merged

Remove unused benchmark fixture in test_dask_mg_random_walks #4391

merged 4 commits into from
May 11, 2024

Conversation

mroeschke
Copy link
Contributor

Removes an easy PytestBenchmarkWarning from the tests

@mroeschke mroeschke requested a review from a team as a code owner May 6, 2024 23:06
@github-actions github-actions bot added the python label May 6, 2024
rlratzel
rlratzel approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll add that back in (and actually use it) when we're ready to do something with benchmark results for this algo.

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 9, 2024
@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 82d2a56 into rapidsai:branch-24.06 May 11, 2024
130 of 131 checks passed
@mroeschke mroeschke deleted the warnings/benchmark branch May 13, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @rlratzel