Use stream_allocator_adaptor constructor instead of factory. #4557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
improvement
jameslamb
previously requested changes
Jul 29, 2024
|
@jameslamb Fixed! Thanks, just forgot to update the base branch when opening. |
bdice
requested review from
jameslamb
and removed request for
a team and
jameslamb
bdice
dismissed
jameslamb’s stale review
CI/packaging reviews not needed after base branch fix
jameslamb
approved these changes
Jul 29, 2024
seunghwak
approved these changes
Jul 31, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the
stream_allocator_adaptorconstructor instead of a factory. With CTAD, we do not need the factory and can use the constructor directly. The factory will be deprecated in rapidsai/rmm#1626.