Updates to cugraph.hypergraph (Duplicate Col Labels Bug)
#4610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
approved these changes
Aug 14, 2024
trxcllnt
approved these changes
Aug 15, 2024
jnke2016
approved these changes
Aug 15, 2024
|
/merge |
rapids-bot
bot
merged commit a538745
into
rapidsai:branch-24.10
109 of 118 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @rlratzel @ChuckHastings
This PR addresses failures seen in certain PRs (like here) due to a recent change to
cudfthat disallows selecting duplicate column labels.In
hypergraph.py, this PR modifies_create_hyper_edgesand_create_direct_edgesto ensure that DataFrames are being indexed by non-duplicate column values.This is done by taking a list that includes duplicates (
fs), and removing the non-unique valuesThis part requires some attention from the author of the unit test @jnke2016
In
test_hypergraph.py, this PR adds thecheck_like=Truearg toassert_frame_equalsfunction because the ordering of the columns is different for the two DFs.