-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR CI: make cugraph builds depend on pylibcugraph builds #4801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. This feels like it was always the intended design, comparing to other RAPIDS repos.
All Python test jobs are failing because of this deprecation warning, treated as an error:
full stack trace (click me)
Just pushed 1a2590a ignoring that warning, as we've done in some other places. If we accept that workaround for now, I'll put up an issue here about resolving those warnings so they don't become errors when those deprecations are eventually enforced in future |
/merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposes the following change to the wheel jobs for PR CI:
Notes for Reviewers
I think reducing the end-to-end time for changes here is even more important now that we have new downstream repos (https://github.com/rapidsai/nx-cugraph and https://github.com/rapidsai/cugraph-gnn) that depend on changes made here.
Benefits of this change
cugraph-cu{11,12}
builds more frequently, which should mean more frequent population of thesccache
cachecugraph-cu{11,12}
build issuesCosts of this change
cugraph
PRs (wheel tests forcugraph
could now occupy 4 GPU runners at once instead of just 2)pylibcugraph
test jobs tend to take around 6-10 minutes once scheduled onto a runner, so this shouldn't be too bad