-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Skip WholeGraph Tests if GPU PyTorch Unavailable #4820
base: branch-25.02
Are you sure you want to change the base?
Conversation
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
For both the title and description, I think you mean "GPU PyTorch" not "CPU PyTorch", right?
Linking the related conversation: #4817 |
Yes, I just corrected it. |
I think we will resolve these sorts of issues for good with #4822 |
This missed 24.12, retargeting it at 25.02. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Re-targeting to |
/merge |
Looks like we still need review from @KyleFromNVIDIA |
We don't, my review was enough for We need a |
@jameslamb you're right, sorry. Let me get someone from our team to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I wonder if we should start using pytestmark though to skip the entire module for these conditions?
Skips WholeGraph tests if GPU PyTorch is not available. Required to get tests passing on ARM. In the future, we should move all WholeGraph-dependent code, as well as the bulk sampling API, into
cugraph-gnn
so these errors do not continue.