Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add un-renumbering to connected components and update tests #771

Merged

Conversation

Iroy30
Copy link
Contributor

@Iroy30 Iroy30 commented Mar 19, 2020

--> Added un-renumbering block to wcc and scc
--> Updated tests to compare vertices for the largest component. This is to ensure correct labeling and un-renumbering. (Previously the test was just comparing number and lengths of components)

closes #767

@Iroy30 Iroy30 requested a review from a team as a code owner March 19, 2020 19:53
@Iroy30 Iroy30 changed the title add unrenumbering to connected components and update tests [REVIEW] Add un-renumbering to connected components and update tests Mar 19, 2020
@BradReesWork BradReesWork added this to the 0.13 milestone Mar 19, 2020
@BradReesWork BradReesWork requested a review from afender March 19, 2020 20:04
Copy link
Member

@afender afender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BradReesWork BradReesWork merged commit 857c234 into rapidsai:branch-0.13 Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] WCC return incorrect results after last update
3 participants