reduce memory_footprint for transform

rapidsai · Jul 12, 2024 · 1c0582b · 1c0582b
1 parent 1e7de60
commit 1c0582b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/python/cuml/decomposition/pca.pyx b/python/cuml/decomposition/pca.pyx
@@ -632,8 +632,9 @@ class PCA(UniversalBase,
                 self.components_ *= cp.sqrt(self.n_samples_ - 1)
                 self.components_ /= self.singular_values_.reshape((-1, 1))
 
-            X = X - self.mean_
-            X_transformed = X.dot(self.components_.T)
+            precomputed_mean_impact = self.mean_ @ self.components_.T
+            mean_impact = cp.ones((X.shape[0], 1)) @ precomputed_mean_impact.reshape(1, -1)
+            X_transformed = X.dot(self.components_.T) -mean_impact
 
             if self.whiten:
                 self.components_ *= self.singular_values_.reshape((-1, 1))