Skip to content

Commit

Permalink
Adapt to rmm logger changes (#6147)
Browse files Browse the repository at this point in the history
This PR adapts to breaking changes in rmm in
rapidsai/rmm#1722.

---------

Co-authored-by: Bradley Dice <bdice@bradleydice.com>
  • Loading branch information
vyasr and bdice authored Dec 2, 2024
1 parent ae9c1ea commit 6f8a189
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -626,9 +626,10 @@ if(BUILD_CUML_CPP_LIBRARY)
)

target_link_libraries(${CUML_CPP_TARGET}
PUBLIC rmm::rmm ${CUVS_LIB}
PUBLIC rmm::rmm rmm::rmm_logger ${CUVS_LIB}
${_cuml_cpp_public_libs}
PRIVATE ${_cuml_cpp_private_libs}
rmm::rmm_logger_impl
)

# If we export the libdmlc symbols, they can lead to weird crashes with other
Expand Down
1 change: 1 addition & 0 deletions cpp/bench/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ if(BUILD_CUML_BENCH)
benchmark::benchmark
${TREELITE_LIBS}
raft::raft
rmm::rmm_logger_impl
)

target_include_directories(${CUML_CPP_BENCH_TARGET}
Expand Down
2 changes: 2 additions & 0 deletions cpp/test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ function(ConfigureTest)
CUDA::cusparse${_ctk_static_suffix}
$<$<BOOL:${LINK_CUFFT}>:CUDA::cufft${_ctk_static_suffix_cufft}>
rmm::rmm
rmm::rmm_logger
rmm::rmm_logger_impl
raft::raft
GTest::gtest
GTest::gtest_main
Expand Down

0 comments on commit 6f8a189

Please sign in to comment.