Skip to content

Commit

Permalink
Fix scikit-learn version specifier (#6158)
Browse files Browse the repository at this point in the history
This version should be `1.5.*`, otherwise this causes pip solves to fail with the following error when included with a wheel downloaded via `pip download`:

```
ERROR: Cannot install scikit-learn, scikit-learn 1.5.2 (from scikit_learn-1.5.2-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl) and scikit-learn==1.5 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested scikit-learn 1.5.2 (from scikit_learn-1.5.2-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl)
    The user requested scikit-learn
    The user requested scikit-learn==1.5

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip to attempt to solve the dependency conflict
```

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #6158
  • Loading branch information
trxcllnt authored Dec 4, 2024
1 parent 53259f5 commit 7e6dbc0
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-118_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ dependencies:
- recommonmark
- rmm==24.12.*,>=0.0.0a0
- scikit-build-core>=0.10.0
- scikit-learn==1.5
- scikit-learn==1.5.*
- scipy>=1.8.0
- seaborn
- spdlog>=1.14.1,<1.15
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-125_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ dependencies:
- recommonmark
- rmm==24.12.*,>=0.0.0a0
- scikit-build-core>=0.10.0
- scikit-learn==1.5
- scikit-learn==1.5.*
- scipy>=1.8.0
- seaborn
- spdlog>=1.14.1,<1.15
Expand Down
2 changes: 1 addition & 1 deletion dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ dependencies:
# https://github.com/pydata/pydata-sphinx-theme/issues/1539
- pydata-sphinx-theme!=0.14.2
- recommonmark
- &scikit_learn scikit-learn==1.5
- &scikit_learn scikit-learn==1.5.*
- sphinx<6
- sphinx-copybutton
- sphinx-markdown-tables
Expand Down
2 changes: 1 addition & 1 deletion python/cuml/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ test = [
"pytest-cov",
"pytest-xdist",
"pytest==7.*",
"scikit-learn==1.5",
"scikit-learn==1.5.*",
"seaborn",
"statsmodels",
"umap-learn==0.5.6",
Expand Down

0 comments on commit 7e6dbc0

Please sign in to comment.