Skip to content

Commit

Permalink
XFail Holt Winters test where statsmodels has known issues with gcc 9…
Browse files Browse the repository at this point in the history
….3.0(#3385)

In PR #3379, we observed this error in statsmodels (obtaining nans) that is unrelated to cuml but occurs with gcc 9.3.0. (See issue #3384.) For now, we will xfail.

Authors:
  - John Zedlewski <jzedlewski@nvidia.com>

Approvers:
  - Dante Gama Dessavre (@dantegd)

URL: #3385
  • Loading branch information
JohnZed authored Jan 20, 2021
1 parent d72c54a commit 816bb65
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions python/cuml/test/test_holtwinters.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ def test_singlets_holtwinters(seasonal, h, datatype):
train = airpassengers[:-h]
test = airpassengers[-h:]

if seasonal == "multiplicative":
pytest.xfail("Statsmodels nan errors with gcc 9.3 (Issue #3384)")

sm_hw = sm_ES(train, seasonal=seasonal,
seasonal_periods=12)
sm_hw = sm_hw.fit()
Expand All @@ -98,6 +101,9 @@ def test_multits_holtwinters(seasonal, h, datatype):
airpassengers = np.asarray(airpassengers, dtype=datatype)
co2 = np.asarray(co2, dtype=datatype)

if seasonal == "multiplicative":
pytest.xfail("Statsmodels nan errors with gcc 9.3 (Issue #3384)")

air_train = airpassengers[:-h]
air_test = airpassengers[-h:]
co2_train = co2[:-h]
Expand Down

0 comments on commit 816bb65

Please sign in to comment.