Skip to content

Commit

Permalink
[REVIEW] better C++ test parameter management (#3088)
Browse files Browse the repository at this point in the history
* draft 1 of better test parameter specification

* refactor using variadic macros; move fil enums to own namespace

* changelog; fixed fil.pyx enum import

* simpler FIL_TEST_PARAMS macro, remove the ::enums:: changes

* leaner change

* renamed struct responsible for non default FIL test parameters

* style
  • Loading branch information
levsnv authored Nov 12, 2020
1 parent 2219a75 commit a6622de
Show file tree
Hide file tree
Showing 3 changed files with 213 additions and 392 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
- PR #3044: Move leftover `linalg` and `stats` to RAFT namespaces
- PR #3067: Deleting prims moved to RAFT and updating header paths
- PR #3074: Reducing dask coordinate descent test runtime
- PR #3088: More readable and robust FIL C++ test management
- PR #3052: Speeding up MNMG KNN Cl&Re testing
- PR #3115: Speeding up MNMG UMAP testing
- PR #3112: Speed test_array
Expand Down
3 changes: 3 additions & 0 deletions cpp/include/cuml/fil/fil.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ enum output_t {
/** output class label: either apply threshold to the output of the previous stage (for binary classification),
or select the class with the most votes to get the class label (for multi-class classification). */
CLASS = 0x100,
SIGMOID_CLASS = SIGMOID | CLASS,
AVG_CLASS = AVG | CLASS,
AVG_SIGMOID_CLASS = AVG | SIGMOID | CLASS,
};

/** storage_type_t defines whether to import the forests as dense or sparse */
Expand Down
Loading

0 comments on commit a6622de

Please sign in to comment.