Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Ignore excessive warnings in pytests / CI logs #2843

Closed
Tracked by #4131
cjnolet opened this issue Sep 18, 2020 · 5 comments · Fixed by #4196
Closed
Tracked by #4131

[BUG] Ignore excessive warnings in pytests / CI logs #2843

cjnolet opened this issue Sep 18, 2020 · 5 comments · Fixed by #4196
Labels
bug Something isn't working inactive-90d

Comments

@cjnolet
Copy link
Member

cjnolet commented Sep 18, 2020

The increase in the number of Python warnings in our CI logs from our pytests have made it increasingly challenging to hunt through the logs searching for potential CI failures.

In this CI log, almost half of the log is filled up with warnings that aren't relevant at all to the tests. We should probably ignore many of these warnings.

@cjnolet cjnolet added bug Something isn't working ? - Needs Triage Need team to review and classify labels Sep 18, 2020
@wphicks
Copy link
Contributor

wphicks commented Sep 24, 2020

Just to confirm, you're talking about the huge number of warnings like the following, yes?

  /opt/conda/envs/rapids/lib/python3.8/site-packages/sklearn/utils/validation.py:68: FutureWarning: Pass eps=0.9109496478186582 as keyword args. From version 0.25 passing these as positional arguments will result in an error
    warnings.warn("Pass {} as keyword args. From version 0.25 "

@wphicks wphicks removed the ? - Needs Triage Need team to review and classify label Sep 24, 2020
@JohnZed
Copy link
Contributor

JohnZed commented Nov 16, 2020

Possible staging / elements:

  • Hide scikit-learn warnings by default
  • Add python wrapper that allows us to fail on any warnings (with ability for expected warnings)
  • Reroute C++ logging through python logger to allow it to participate in python fail options

See also: adding log_once / warn_once to reduce spew consistently

@JohnZed
Copy link
Contributor

JohnZed commented Nov 16, 2020

See also:

  • Adding custom SummaryWriter that will make it easier to find and view error

@github-actions
Copy link

This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@github-actions
Copy link

This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.

@rapids-bot rapids-bot bot closed this as completed in #4196 Nov 8, 2021
rapids-bot bot pushed a commit that referenced this issue Nov 8, 2021
Partially resolves #2843 

Missing to deal with is warnings coming from cuML logger and other verbosity in the C++ layer

Note: Scikit-learn 0.24 removes many warnings as well, so once #4205 is merged and that is updated in CI the remaining warnings should be gone

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #4196
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this issue Oct 9, 2023
Partially resolves rapidsai#2843 

Missing to deal with is warnings coming from cuML logger and other verbosity in the C++ layer

Note: Scikit-learn 0.24 removes many warnings as well, so once rapidsai#4205 is merged and that is updated in CI the remaining warnings should be gone

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working inactive-90d
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants