Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Remove deprecated spmg_ipc code #2979

Closed
JohnZed opened this issue Oct 14, 2020 · 1 comment · Fixed by #3004
Closed

[FEA] Remove deprecated spmg_ipc code #2979

JohnZed opened this issue Oct 14, 2020 · 1 comment · Fixed by #3004
Labels
feature request New feature or request good first issue Good for newcomers Multi-GPU Issues & PRs related to multi-GPU functionality quick-hit <1 day task we should just do

Comments

@JohnZed
Copy link
Contributor

JohnZed commented Oct 14, 2020

This is a real antique and should not be used. SPMG (single process, multiple-GPU) has been deprecated for a while. Should just remove this.
@JohnZed JohnZed added feature request New feature or request ? - Needs Triage Need team to review and classify labels Oct 14, 2020
@JohnZed JohnZed added good first issue Good for newcomers and removed ? - Needs Triage Need team to review and classify labels Oct 14, 2020
@JohnZed JohnZed mentioned this issue Oct 14, 2020
Merged
@viclafargue viclafargue added Multi-GPU Issues & PRs related to multi-GPU functionality quick-hit <1 day task we should just do good first issue Good for newcomers and removed good first issue Good for newcomers labels Oct 14, 2020
@jameslamb
Copy link
Member

based on #2976 (comment), I'd like to pick this up

@jameslamb jameslamb mentioned this issue Oct 16, 2020
Merged
dantegd pushed a commit that referenced this issue Oct 20, 2020
@jameslamb
[REVIEW] remove Single Process Multi GPU (SPMG) code (fixes #2979) (#…
83d072d 
…3004)

* remove Single Process Multi GPU (SPMG) code (fixes #2979)

* add changelog entry

* move changelog entry

* whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request good first issue Good for newcomers Multi-GPU Issues & PRs related to multi-GPU functionality quick-hit <1 day task we should just do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] remove Single Process Multi GPU (SPMG) code (fixes #2979)
3 participants
@JohnZed @jameslamb @viclafargue