Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Enhance documentation for MNMG KNN #3232

Closed
beckernick opened this issue Dec 2, 2020 · 1 comment
Closed

[DOC] Enhance documentation for MNMG KNN #3232

beckernick opened this issue Dec 2, 2020 · 1 comment
Assignees
@viclafargue
Labels
? - Needs Triage Need team to review and classify doc Documentation

Comments

@beckernick
Copy link
Member

As noted in https://stackoverflow.com/questions/64785654/why-is-cuml-predict-method-for-knearestneighbors-taking-so-long-with-dask-cudf , the batch_size parameter is important for throughput. This is currently an undocumented parameter, as the KNeighborsRegressorMG class accepts it but the dask KNeighborsRegressor accepts it only through **kwargs.

We should document all relevant parameters for MNMG KNN.
@beckernick beckernick added ? - Needs Triage Need team to review and classify doc Documentation labels Dec 2, 2020
@viclafargue viclafargue mentioned this issue Dec 3, 2020
Merged
rapids-bot bot pushed a commit that referenced this issue Dec 5, 2020
@viclafargue
Fix MNMG KNN doc (adding batch_size)(#3246)
d063ca4 
Answers #3232.
Explicitly specify `batch_size` as parameter to MNMG KNN models in order to make it visible in the documentation.

Authors:
  - viclafargue <viclafargue@nvidia.com>
  - Corey J. Nolet <cjnolet@gmail.com>

Approvers:
  - Corey J. Nolet
  - John Zedlewski

URL: #3246
@viclafargue
Copy link
Contributor

Solved with #3246.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viclafargue viclafargue

Labels
? - Needs Triage Need team to review and classify doc Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beckernick @viclafargue