Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] test_naive_bayes should use local data / not download #3260

Closed
JohnZed opened this issue Dec 4, 2020 · 1 comment · Fixed by #3291
Closed

[BUG] test_naive_bayes should use local data / not download #3260

JohnZed opened this issue Dec 4, 2020 · 1 comment · Fixed by #3291
Assignees
@lowener
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@JohnZed
Copy link
Contributor

JohnZed commented Dec 4, 2020

We've seen several cases where downloading the newsgroups dataset for test_naive_bayes times out in CI, causing a failed test. We should either make this test optional or replace the dataset used.
@JohnZed JohnZed added bug Something isn't working ? - Needs Triage Need team to review and classify labels Dec 4, 2020
@cjnolet cjnolet self-assigned this Dec 5, 2020
@cjnolet cjnolet removed their assignment Dec 5, 2020
@JohnZed JohnZed assigned lowener and JohnZed and unassigned lowener Dec 8, 2020
@JohnZed
Copy link
Contributor Author

JohnZed commented Dec 8, 2020

Let's xfail with a reason of the network error exception. I believe this is an IOError? https://docs.pytest.org/en/latest/skipping.html
Should still fail if there are other exceptions.

@JohnZed JohnZed assigned lowener and unassigned JohnZed Dec 8, 2020
@lowener lowener mentioned this issue Dec 10, 2020
Merged
rapids-bot bot pushed a commit that referenced this issue Dec 14, 2020
@lowener
Add xfail on fetching 20newsgroup dataset (test_naive_bayes)(#3291)
34efaf8 
This PR fixes CI fails that happen on `test_naive_bayes` when the machine can't download the 20 newsgroup dataset.

It closes #3260

Authors:
  - Mickael Ide <ide.mickael@gmail.com>

Approvers:
  - John Zedlewski

URL: #3291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lowener lowener

Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Add xfail on fetching 20newsgroup dataset (test_naive_bayes) lowener/cuml
3 participants
@JohnZed @cjnolet @lowener