Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Import compatible meta-estimators (e.g. pipelines) from sklearn into namespace #3484

Closed
JohnZed opened this issue Feb 11, 2021 · 1 comment · Fixed by #3493
Closed

[FEA] Import compatible meta-estimators (e.g. pipelines) from sklearn into namespace #3484

JohnZed opened this issue Feb 11, 2021 · 1 comment · Fixed by #3493
Labels
? - Needs Triage Need team to review and classify feature request New feature or request inactive-30d

Comments

@JohnZed
Copy link
Contributor

JohnZed commented Feb 11, 2021

Topic for discussion!

Many sklearn meta-estimator features, like Pipeline and GridSearch are fully compatible with cuML models. Many users do not know this. They try to import "cuml.pipeline.Pipeline", find nothing, and assume we do not support these features.

It does not seem wise to simply duplicate these already well-built classes. Alternatively, we could simply import from sklearn into our namespaces to match the existing namespace layout. To accompany this, we would need to add unit test coverage to ensure we never break compatibility.
@JohnZed JohnZed added feature request New feature or request ? - Needs Triage Need team to review and classify labels Feb 11, 2021
@viclafargue viclafargue mentioned this issue Feb 12, 2021
Merged
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

rapids-bot bot pushed a commit that referenced this issue Mar 16, 2021
@viclafargue
Sklearn meta-estimators into namespace (#3493)
28c3e39 
Closes #3484

Imports sklearn's Pipeline and GridSearch meta-estimators into cuML namespace for ease-of-use.

Authors:
  - Victor Lafargue (@viclafargue)

Approvers:
  - William Hicks (@wphicks)
  - John Zedlewski (@JohnZed)

URL: #3493
@JohnZed JohnZed mentioned this issue Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify feature request New feature or request inactive-30d
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Sklearn meta-estimators into namespace viclafargue/cuml
1 participant
@JohnZed