Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Enable warnings as error during libcuml compilation #4086

Closed
dantegd opened this issue Jul 22, 2021 · 0 comments · Fixed by #4075
Closed

[FEA] Enable warnings as error during libcuml compilation #4086

dantegd opened this issue Jul 22, 2021 · 0 comments · Fixed by #4075
Labels
? - Needs Triage Need team to review and classify CMake CUDA / C++ CUDA issue feature request New feature or request Tech Debt Issues related to debt

Comments

@dantegd
Copy link
Member

dantegd commented Jul 22, 2021

Creating issue to track PR #4075 since I don't think we had another issue.
@dantegd dantegd added feature request New feature or request ? - Needs Triage Need team to review and classify CUDA / C++ CUDA issue Tech Debt Issues related to debt CMake labels Jul 22, 2021
@harrism harrism mentioned this issue Jul 27, 2021
Merged
@dantegd dantegd mentioned this issue Jul 29, 2021
Open
11 tasks
rapids-bot bot pushed a commit that referenced this issue Aug 10, 2021
@harrism
Warnings are errors (#4075)
e977f3e 
Depends on rapidsai/raft#299
Depends on rapidsai/raft#311

Fixes #4086

This PR enables -Wall (warnings are errors) and fixes all current compiler warnings.

Compiler warnings should almost never be ignored. -Wall helps prevent hard-to-find bugs.

Tested with both Release and Debug builds since more warnings are typically reported in debug builds.

In any file I touched, I also cleaned up the includes so that they are grouped and sorted and ordered from "near" to "far" (relative to the file that is including).

Also cleaned up many instances of `size_t` --> `std::size_t`, however I will leave a global search and replace for a separate PR to make reviewing easier.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - William Hicks (https://github.com/wphicks)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4075
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this issue Oct 9, 2023
@harrism
Warnings are errors (rapidsai#4075)
a1f972b 
Depends on rapidsai/raft#299
Depends on rapidsai/raft#311

Fixes rapidsai#4086

This PR enables -Wall (warnings are errors) and fixes all current compiler warnings.

Compiler warnings should almost never be ignored. -Wall helps prevent hard-to-find bugs.

Tested with both Release and Debug builds since more warnings are typically reported in debug builds.

In any file I touched, I also cleaned up the includes so that they are grouped and sorted and ordered from "near" to "far" (relative to the file that is including).

Also cleaned up many instances of `size_t` --> `std::size_t`, however I will leave a global search and replace for a separate PR to make reviewing easier.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - William Hicks (https://github.com/wphicks)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4075
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify CMake CUDA / C++ CUDA issue feature request New feature or request Tech Debt Issues related to debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warnings are errors harrism/cuml
1 participant
@dantegd