Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Finish porting sklearn preprocessing- PowerTransformer and QuantileTransformer #4622

Closed
esnvidia opened this issue Mar 7, 2022 · 3 comments · Fixed by #4755
Closed

[FEA] Finish porting sklearn preprocessing- PowerTransformer and QuantileTransformer #4622

esnvidia opened this issue Mar 7, 2022 · 3 comments · Fixed by #4755
Assignees
@viclafargue
Labels
feature request New feature or request good first issue Good for newcomers

Comments

@esnvidia
Copy link

esnvidia commented Mar 7, 2022

I noticed that PowerTransformer and QuantileTransformer are in cuMLs repo, copied from sklearn but not available for use

It seems like StandardScaler, and some others in this file that are used in cuML.

This FR is to port these two common data transformation methods to cuML, along with corresponding tests
@esnvidia esnvidia added ? - Needs Triage Need team to review and classify feature request New feature or request labels Mar 7, 2022
@divyegala
Copy link
Member

@viclafargue can you respond to this one?

@viclafargue
Copy link
Contributor

Thanks for noticing that. That is indeed something that we will have to work on for future releases.

@viclafargue viclafargue self-assigned this Mar 29, 2022
@divyegala divyegala removed the ? - Needs Triage Need team to review and classify label Mar 29, 2022
@beckernick
Copy link
Member

Perhaps this is a good first issue for a contributor?

@beckernick beckernick added the good first issue Good for newcomers label Apr 18, 2022
@viclafargue viclafargue mentioned this issue May 24, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Sep 11, 2022
@viclafargue
PowerTransformer, QuantileTransformer and KernelCenterer (#4755)
74372f3 
Closes #4622

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Micka (https://github.com/lowener)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #4755
jakirkham pushed a commit to jakirkham/cuml that referenced this issue Feb 27, 2023
@viclafargue
PowerTransformer, QuantileTransformer and KernelCenterer (rapid…
72e12b2 
…sai#4755)

Closes rapidsai#4622

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Micka (https://github.com/lowener)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viclafargue viclafargue

Labels
feature request New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PowerTransformer, QuantileTransformer and KernelCenterer viclafargue/cuml
4 participants
@beckernick @viclafargue @divyegala @esnvidia