Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting all cuml tests to pass with cudf.pandas enabled #5876

Open
18 tasks
betatim opened this issue Apr 30, 2024 · 3 comments
Open
18 tasks

Getting all cuml tests to pass with cudf.pandas enabled #5876

betatim opened this issue Apr 30, 2024 · 3 comments

Comments

@betatim
Copy link
Member

betatim commented Apr 30, 2024 •
edited
Loading

This issue is the result of running the cuml tests with pytest -p cudf.pandas --ignore=dask -m "not memleak". The goal is to find out how well cuml works with cudf.pandas activated. As far as I can tell this actually means at least two things: (1) cudf's "pandas compatibility mode" is activated and (2) the cudf.pandas accelerator is doing its magic. We could look at (1) separately, for example users of cuml might turn on this option even without using the pandas accelerator.

The goal of this issue is to have a central list of all failing tests so we can coordinate working on getting them fixed. I think it would make sense to open one PR per test file or even one PR for a set of tests in one file. That way the diff stays manageable for the reviewer and we don't have too many PRs. Post in this issue if you are working on one of these so we can avoid duplicate effort.

The failures in test_one_hot_encoder.py might be a bit harder to solve than the other ones, so I singled them out.

I used 6d3bb0d and a conda environment setup today.

The tests in test_one_hot_encoder.py cause trouble with cudf.pandas activated. Several of them lead to MemoryError or CUDARuntimeErrors. Example output below.

Full list of failed tests in `test_one_hot_encoder.py` 
==================================================================================== short test summary info ====================================================================================
FAILED test_one_hot_encoder.py::test_onehot_inverse_transform[cupy-first] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_one_hot_encoder.py::test_onehot_inverse_transform[cupy-drop2] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_one_hot_encoder.py::test_onehot_inverse_transform[cudf-first] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_one_hot_encoder.py::test_onehot_inverse_transform[cudf-drop2] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cupy-10-sparse-first] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cupy-10-dense-first] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cupy-1000-sparse-first] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cupy-1000-dense-first] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cupy-20000-sparse-first] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cupy-20000-dense-first] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cudf-10-sparse-None] - RuntimeError: CUDA error at: /opt/conda/conda-bld/work/cpp/build/_deps/cuco-src/include/cuco/detail/static_map.inl111: cudaErrorIllegalAddress an illegal memory access was encountered
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cudf-10-sparse-first] - MemoryError: std::bad_alloc: CUDA error at: /opt/conda/conda-bld/work/include/rmm/mr/device/cuda_memory_resource.hpp:60: cudaErrorIllegalAddress an illegal memory access was encountered
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cudf-10-dense-None] - MemoryError: std::bad_alloc: CUDA error at: /opt/conda/conda-bld/work/include/rmm/mr/device/cuda_memory_resource.hpp:60: cudaErrorIllegalAddress an illegal memory access was encountered
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cudf-10-dense-first] - MemoryError: std::bad_alloc: CUDA error at: /opt/conda/conda-bld/work/include/rmm/mr/device/cuda_memory_resource.hpp:60: cudaErrorIllegalAddress an illegal memory access was encountered
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cudf-1000-sparse-None] - MemoryError: std::bad_alloc: CUDA error at: /opt/conda/conda-bld/work/include/rmm/mr/device/cuda_memory_resource.hpp:60: cudaErrorIllegalAddress an illegal memory access was encountered
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cudf-1000-sparse-first] - MemoryError: std::bad_alloc: CUDA error at: /opt/conda/conda-bld/work/include/rmm/mr/device/cuda_memory_resource.hpp:60: cudaErrorIllegalAddress an illegal memory access was encountered
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cudf-1000-dense-None] - MemoryError: std::bad_alloc: CUDA error at: /opt/conda/conda-bld/work/include/rmm/mr/device/cuda_memory_resource.hpp:60: cudaErrorIllegalAddress an illegal memory access was encountered
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cudf-1000-dense-first] - MemoryError: std::bad_alloc: CUDA error at: /opt/conda/conda-bld/work/include/rmm/mr/device/cuda_memory_resource.hpp:60: cudaErrorIllegalAddress an illegal memory access was encountered
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cudf-20000-sparse-None] - MemoryError: std::bad_alloc: CUDA error at: /opt/conda/conda-bld/work/include/rmm/mr/device/cuda_memory_resource.hpp:60: cudaErrorIllegalAddress an illegal memory access was encountered
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cudf-20000-sparse-first] - MemoryError: std::bad_alloc: CUDA error at: /opt/conda/conda-bld/work/include/rmm/mr/device/cuda_memory_resource.hpp:60: cudaErrorIllegalAddress an illegal memory access was encountered
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cudf-20000-dense-None] - MemoryError: std::bad_alloc: CUDA error at: /opt/conda/conda-bld/work/include/rmm/mr/device/cuda_memory_resource.hpp:60: cudaErrorIllegalAddress an illegal memory access was encountered
FAILED test_one_hot_encoder.py::test_onehot_random_inputs[cudf-20000-dense-first] - MemoryError: std::bad_alloc: CUDA error at: /opt/conda/conda-bld/work/include/rmm/mr/device/cuda_memory_resource.hpp:60: cudaErrorIllegalAddress an illegal memory access was encountered
FAILED test_one_hot_encoder.py::test_onehot_drop_idx_first[cupy] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_drop_idx_first[cudf] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_drop_one_of_each[cupy] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_drop_one_of_each[cudf] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_drop_exceptions[cupy-drop0-`drop` should have as many columns] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_drop_exceptions[cupy-drop1-Trying to drop multiple values] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_drop_exceptions[cupy-drop2-Some categories [0-9a-zA-Z, ]* were not found] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_drop_exceptions[cupy-drop3-Wrong input for parameter `drop`.] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_drop_exceptions[cudf-drop0-`drop` should have as many columns] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_drop_exceptions[cudf-drop1-Trying to drop multiple values] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_drop_exceptions[cudf-drop2-Some categories [0-9a-zA-Z, ]* were not found] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_drop_exceptions[cudf-drop3-Wrong input for parameter `drop`.] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_get_categories[cupy] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_get_categories[cudf] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_sparse_drop[cupy] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_sparse_drop[cudf] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_categories_shape_mismatch[cupy] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_categories_shape_mismatch[cudf] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_category_specific_cases - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_category_class_count[uint8] - cupy_backends.cuda.api.runtime.CUDARuntimeError: cudaErrorIllegalAddress: an illegal memory access was encountered
FAILED test_one_hot_encoder.py::test_onehot_category_class_count[uint16] - cupy_backends.cuda.api.runtime.CUDARuntimeError: cudaErrorIllegalAddress: an illegal memory access was encountered
FAILED test_one_hot_encoder.py::test_onehot_get_feature_names[cupy] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
FAILED test_one_hot_encoder.py::test_onehot_get_feature_names[cudf] - MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp
example test with `CUDARuntimeError` 
____________________________________________________________________________ test_onehot_category_class_count[uint8] ____________________________________________________________________________

total_classes = 255

    @pytest.mark.parametrize(
        "total_classes",
        [np.iinfo(np.uint8).max, np.iinfo(np.uint16).max],
        ids=["uint8", "uint16"],
    )
    def test_onehot_category_class_count(total_classes: int):
        # See this for reasoning: https://github.com/rapidsai/cuml/issues/2690
        # All tests use sparse=True to avoid memory errors

        encoder = OneHotEncoder(handle_unknown="ignore", sparse=True)

        # ==== 2 Rows ====
        example_df = DataFrame()
>       example_df["high_cardinality_column"] = cp.linspace(
            0, total_classes - 1, total_classes
        )

test_one_hot_encoder.py:328:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/nvme/1/thead/miniconda/envs/cuml-dev-24.06/lib/python3.11/site-packages/cupy/_creation/ranges.py:161: in linspace
    return _linspace_scalar(start, stop, num, endpoint, retstep, dtype)
/nvme/1/thead/miniconda/envs/cuml-dev-24.06/lib/python3.11/site-packages/cupy/_creation/ranges.py:91: in _linspace_scalar
    ret = cupy.empty((num,), dtype=dt)
/nvme/1/thead/miniconda/envs/cuml-dev-24.06/lib/python3.11/site-packages/cupy/_creation/basic.py:31: in empty
    return cupy.ndarray(shape, dtype, order=order)
cupy/_core/core.pyx:132: in cupy._core.core.ndarray.__new__
    ???
cupy/_core/core.pyx:220: in cupy._core.core._ndarray_base._init
    ???
cupy/cuda/memory.pyx:738: in cupy.cuda.memory.alloc
    ???
cupy/cuda/memory.pyx:633: in cupy.cuda.memory._malloc
    ???
cupy/cuda/memory.pyx:634: in cupy.cuda.memory._malloc
    ???
cupy/cuda/memory.pyx:101: in cupy.cuda.memory.Memory.__init__
    ???
cupy_backends/cuda/api/runtime.pyx:498: in cupy_backends.cuda.api.runtime.malloc
    ???
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

>   ???
E   cupy_backends.cuda.api.runtime.CUDARuntimeError: cudaErrorIllegalAddress: an illegal memory access was encountered

cupy_backends/cuda/api/runtime.pyx:146: CUDARuntimeError
example test with `MemoryError` 
____________________________________________________________ test_onehot_drop_exceptions[cudf-drop1-Trying to drop multiple values] _____________________________________________________________

drop = {'chars': 'b', 'int': [2, 0]}, pattern = 'Trying to drop multiple values', as_array = False

    @pytest.mark.parametrize(
        "drop, pattern",
        [
            [dict({"chars": "b"}), "`drop` should have as many columns"],
            [
                dict({"chars": "b", "int": [2, 0]}),
                "Trying to drop multiple values",
            ],
            [
                dict({"chars": "b", "int": 3}),
                "Some categories [0-9a-zA-Z, ]* were not found",
            ],
            [
                DataFrame({"chars": "b", "int": 3}),
                "Wrong input for parameter `drop`.",
            ],
        ],
    )
    @pytest.mark.parametrize("as_array", [True, False], ids=["cupy", "cudf"])
    def test_onehot_drop_exceptions(drop, pattern, as_array):
>       X = DataFrame({"chars": ["c", "b", "d"], "int": [2, 1, 0]})

test_one_hot_encoder.py:237:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/nvme/1/thead/miniconda/envs/cuml-dev-24.06/lib/python3.11/site-packages/nvtx/nvtx.py:116: in inner
    result = func(*args, **kwargs)
/nvme/1/thead/miniconda/envs/cuml-dev-24.06/lib/python3.11/site-packages/cudf/core/dataframe.py:848: in __init__
    self._init_from_dict_like(
/nvme/1/thead/miniconda/envs/cuml-dev-24.06/lib/python3.11/site-packages/nvtx/nvtx.py:116: in inner
    result = func(*args, **kwargs)
/nvme/1/thead/miniconda/envs/cuml-dev-24.06/lib/python3.11/site-packages/cudf/core/dataframe.py:1066: in _init_from_dict_like
    keys, values, lengths = zip(
/nvme/1/thead/miniconda/envs/cuml-dev-24.06/lib/python3.11/site-packages/cudf/core/dataframe.py:1072: in <genexpr>
    vc := as_column(v, nan_as_null=nan_as_null),
/nvme/1/thead/miniconda/envs/cuml-dev-24.06/lib/python3.11/site-packages/cudf/core/column/column.py:2181: in as_column
    return as_column(arbitrary, nan_as_null=nan_as_null, dtype=dtype)
/nvme/1/thead/miniconda/envs/cuml-dev-24.06/lib/python3.11/site-packages/cudf/core/column/column.py:1819: in as_column
    col = ColumnBase.from_arrow(arbitrary)
/nvme/1/thead/miniconda/envs/cuml-dev-24.06/lib/python3.11/site-packages/cudf/core/column/column.py:378: in from_arrow
    result = libcudf.interop.from_arrow(data)[0]
/nvme/1/thead/miniconda/envs/cuml-dev-24.06/lib/python3.11/contextlib.py:81: in inner
    return func(*args, **kwds)
interop.pyx:162: in cudf._lib.interop.from_arrow
    ???
/nvme/1/thead/miniconda/envs/cuml-dev-24.06/lib/python3.11/functools.py:909: in wrapper
    return dispatch(args[0].__class__)(*args, **kw)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

>   ???
E   MemoryError: std::bad_alloc: CUDA error at: /nvme/1/thead/miniconda/envs/cuml-dev-24.06/include/rmm/mr/device/cuda_memory_resource.hpp

interop.pyx:85: MemoryError

For the rest of the tests the results look like this:

  • test_compose.py::test_column_transformer_index
  • test_doctest.py::test_docstring
  • test_holtwinters.py::test_singlets_holtwinters
  • test_input_utils.py::test_convert_matrix_order_cuml_array Fix cudf.pandas failure on test_convert_matrix_order_cuml_array #5882
  • test_input_utils.py::test_convert_input_dtype Fix cudf.pandas failure on test_convert_input_dtype #5885
  • test_label_encoder.py::test_inverse_transform
  • test_label_encoder.py::test_empty_input
  • test_label_encoder.py::test_inverse_transform_cupy_numpy
  • test_metrics.py::test_sklearn_search
  • test_module_config.py::test_default_global_output_type
  • test_ordinal_encoder.py::test_ordinal_encoder_df
  • test_ordinal_encoder.py::test_ordinal_encoder_array
  • test_ordinal_encoder.py::test_output_type
  • test_target_encoder.py::test_targetencoder_random
  • test_target_encoder.py::test_targetencoder_median
  • test_tsne.py::test_tsne_knn_graph_used
  • test_tsne.py::test_tsne
  • explainer/test_sampling.py::test_kmeans_input
==================================================================================== short test summary info ====================================================================================
FAILED test_compose.py::test_column_transformer_index[dataframe] - ValueError: Unsupported dtype object
FAILED test_compose.py::test_column_transformer_index[cudf] - ValueError: Unsupported dtype object
FAILED test_doctest.py::test_docstring[LabelEncoder] - AssertionError: 2 of 18 doctests failed for LabelEncoder:
FAILED test_holtwinters.py::test_singlets_holtwinters[float64-12-additive] - TypeError: ExponentialSmoothing.__init__() missing 1 required positional argument: 'endog'
FAILED test_holtwinters.py::test_singlets_holtwinters[float64-24-additive] - TypeError: ExponentialSmoothing.__init__() missing 1 required positional argument: 'endog'
FAILED test_holtwinters.py::test_multits_holtwinters[float64-12-additive] - TypeError: ExponentialSmoothing.__init__() missing 1 required positional argument: 'endog'
FAILED test_holtwinters.py::test_multits_holtwinters[float64-24-additive] - TypeError: ExponentialSmoothing.__init__() missing 1 required positional argument: 'endog'
FAILED test_input_utils.py::test_convert_matrix_order_cuml_array[K-C-pandas-float32] - AssertionError: assert 'F' == 'C'
FAILED test_input_utils.py::test_convert_matrix_order_cuml_array[K-C-pandas-float64] - AssertionError: assert 'F' == 'C'
FAILED test_input_utils.py::test_convert_matrix_order_cuml_array[K-F-pandas-float32] - AssertionError: assert 'F' == 'C'
FAILED test_input_utils.py::test_convert_matrix_order_cuml_array[K-F-pandas-float64] - AssertionError: assert 'F' == 'C'
FAILED test_input_utils.py::test_convert_input_dtype[C-pandas-float32-float32-1-1] - assert 139772184412160 == 139770577912832
FAILED test_input_utils.py::test_convert_input_dtype[C-pandas-float32-float32-1-100] - assert 139773354852864 == 139770566459904
FAILED test_input_utils.py::test_convert_input_dtype[C-pandas-float32-float32-100-1] - assert 139768901078528 == 139768901079040
FAILED test_input_utils.py::test_convert_input_dtype[C-pandas-float32-float32-100-100] - assert 139754975141888 == 139754753326592
FAILED test_input_utils.py::test_convert_input_dtype[C-pandas-float64-float64-1-1] - assert 139754975238656 == 139754975239168
FAILED test_input_utils.py::test_convert_input_dtype[C-pandas-float64-float64-1-100] - assert 139769023965184 == 139769023966208
FAILED test_input_utils.py::test_convert_input_dtype[C-pandas-float64-float64-100-1] - assert 139768900565504 == 139768900566528
FAILED test_input_utils.py::test_convert_input_dtype[C-pandas-float64-float64-100-100] - assert 139768900010496 == 139769023652864
FAILED test_input_utils.py::test_convert_input_dtype[F-pandas-float32-float32-1-1] - assert 139772184417280 == 139770566459904
FAILED test_input_utils.py::test_convert_input_dtype[F-pandas-float32-float32-1-100] - assert 139773355484672 == 139772184384512
FAILED test_input_utils.py::test_convert_input_dtype[F-pandas-float32-float32-100-1] - assert 139768901078528 == 139768901079040
FAILED test_input_utils.py::test_convert_input_dtype[F-pandas-float32-float32-100-100] - assert 139754975141888 == 139754753326592
FAILED test_input_utils.py::test_convert_input_dtype[F-pandas-float64-float64-1-1] - assert 139754751172608 == 139754751173120
FAILED test_input_utils.py::test_convert_input_dtype[F-pandas-float64-float64-1-100] - assert 139754752503808 == 139754752504832
FAILED test_input_utils.py::test_convert_input_dtype[F-pandas-float64-float64-100-1] - assert 139768900628992 == 139768900630016
FAILED test_input_utils.py::test_convert_input_dtype[F-pandas-float64-float64-100-100] - assert 139754752647680 == 139754751660544
FAILED test_label_encoder.py::test_inverse_transform[orig_label0-ord_label0-expected_reverted0-bad_ord_label0-False] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_label_encoder.py::test_inverse_transform[orig_label0-ord_label0-expected_reverted0-bad_ord_label0-True] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_label_encoder.py::test_inverse_transform[orig_label1-ord_label1-expected_reverted1-bad_ord_label1-False] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_label_encoder.py::test_inverse_transform[orig_label1-ord_label1-expected_reverted1-bad_ord_label1-True] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_label_encoder.py::test_inverse_transform[orig_label2-ord_label2-expected_reverted2-bad_ord_label2-False] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_label_encoder.py::test_inverse_transform[orig_label2-ord_label2-expected_reverted2-bad_ord_label2-True] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_label_encoder.py::test_inverse_transform[orig_label3-ord_label3-expected_reverted3-bad_ord_label3-False] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_label_encoder.py::test_inverse_transform[orig_label3-ord_label3-expected_reverted3-bad_ord_label3-True] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_label_encoder.py::test_empty_input[empty0-ord_label0] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_label_encoder.py::test_inverse_transform_cupy_numpy[orig_label0-ord_label0-expected_reverted0-bad_ord_label0-False] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_label_encoder.py::test_inverse_transform_cupy_numpy[orig_label0-ord_label0-expected_reverted0-bad_ord_label0-True] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_label_encoder.py::test_inverse_transform_cupy_numpy[orig_label1-ord_label1-expected_reverted1-bad_ord_label1-False] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_label_encoder.py::test_inverse_transform_cupy_numpy[orig_label1-ord_label1-expected_reverted1-bad_ord_label1-True] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_metrics.py::test_sklearn_search - AssertionError: assert {'alpha': 0.09999999999999999} == {'alpha': 0.1}
FAILED test_module_config.py::test_default_global_output_type[pandas] - AssertionError: assert False
FAILED test_ordinal_encoder.py::test_ordinal_encoder_df - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_ordinal_encoder.py::test_ordinal_encoder_array - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_ordinal_encoder.py::test_output_type - AssertionError: assert False
FAILED test_target_encoder.py::test_targetencoder_random[median-int32-5000] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_target_encoder.py::test_targetencoder_random[median-int32-500000] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_target_encoder.py::test_targetencoder_random[median-int64-5000] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_target_encoder.py::test_targetencoder_random[median-int64-500000] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_target_encoder.py::test_targetencoder_random[median-float32-5000] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_target_encoder.py::test_targetencoder_random[median-float32-500000] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_target_encoder.py::test_targetencoder_random[median-float64-5000] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_target_encoder.py::test_targetencoder_random[median-float64-500000] - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_target_encoder.py::test_targetencoder_median - AttributeError: 'ndarray' object has no attribute 'values_host'
FAILED test_tsne.py::test_tsne_knn_graph_used[deprecated_boston_dataset-fft-cuml] - TypeError: Implicit conversion to a NumPy array is not allowed. Please use `.get()` to construct a NumPy array explicitly.
FAILED test_tsne.py::test_tsne_knn_graph_used[deprecated_boston_dataset-fft-sklearn] - TypeError: Implicit conversion to a NumPy array is not allowed. Please use `.get()` to construct a NumPy array explicitly.
FAILED test_tsne.py::test_tsne_knn_graph_used[deprecated_boston_dataset-barnes_hut-cuml] - TypeError: Implicit conversion to a NumPy array is not allowed. Please use `.get()` to construct a NumPy array explicitly.
FAILED test_tsne.py::test_tsne_knn_graph_used[deprecated_boston_dataset-barnes_hut-sklearn] - TypeError: Implicit conversion to a NumPy array is not allowed. Please use `.get()` to construct a NumPy array explicitly.
FAILED test_tsne.py::test_tsne[deprecated_boston_dataset-fft] - TypeError: Implicit conversion to a NumPy array is not allowed. Please use `.get()` to construct a NumPy array explicitly.
FAILED test_tsne.py::test_tsne[deprecated_boston_dataset-barnes_hut] - TypeError: Implicit conversion to a NumPy array is not allowed. Please use `.get()` to construct a NumPy array explicitly.
FAILED explainer/test_sampling.py::test_kmeans_input[pandas-series] - AssertionError: assert False
@vyasr
Copy link
Contributor

vyasr commented Apr 30, 2024

CC @galipremsagar

@betatim
Copy link
Member Author

betatim commented May 2, 2024

Maybe the first thing to do is to add a additional workflow/CI run that is optional (it failing doesn't block merging) that runs pytest -p cudf.pandas --ignore=dask -m "not memleak" (seems to be the main way tests are run?). That way we can get "live feedback" on the progress and see that the test a PR says it fixes does indeed pass now.

Once all tests pass we can then make it a required workflow so that we don't regress.

This was referenced May 2, 2024
Merged
Merged
rapids-bot bot pushed a commit that referenced this issue May 6, 2024
@dantegd
Add optional CI job for integration tests with cudf.pandas (#5881)
68d4336 
cc @betatim 

This PR adds the CI jobs proposed in #5876

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #5881
@dantegd
Copy link
Member

dantegd commented May 7, 2024 

FAILED test_input_utils.py::test_convert_matrix_order_cuml_array[K-C-pandas-float32] - AssertionError: assert 'F' == 'C'
FAILED test_input_utils.py::test_convert_matrix_order_cuml_array[K-C-pandas-float64] - AssertionError: assert 'F' == 'C'
FAILED test_input_utils.py::test_convert_matrix_order_cuml_array[K-F-pandas-float32] - AssertionError: assert 'F' == 'C'
FAILED test_input_utils.py::test_convert_matrix_order_cuml_array[K-F-pandas-float64] - AssertionError: assert 'F' == 'C'

are fixed in PR #5882

@dantegd dantegd mentioned this issue May 7, 2024
Merged
rapids-bot bot pushed a commit that referenced this issue Jun 6, 2024
@dantegd
Fix cudf.pandas failure on test_convert_input_dtype (#5885)
3e8f1ff 
This failure was just a testing failure, expectint identical pointers of actual dataframes, as opposed to wrapped objects. 

Contributes to fixing #5876 

cc @betatim

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Divye Gala (https://github.com/divyegala)

URL: #5885
rapids-bot bot pushed a commit that referenced this issue Jun 6, 2024
@dantegd
Fix cudf.pandas failure on test_convert_matrix_order_cuml_array (#…
dc32b02 
…5882)

Error came from the fact that pandas and cudf convert to numpy by default with different order. 

Towards fixing #5876

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Divye Gala (https://github.com/divyegala)
  - Tim Head (https://github.com/betatim)

URL: #5882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dantegd @betatim @vyasr