-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Approximate Nearest Neighbors #2780
Merged
rapids-bot
merged 30 commits into
rapidsai:branch-0.18
from
viclafargue:fea-multiple-knn-strategies
Dec 14, 2020
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
4124e5a
Multiple KNN strategies (implementing PQ)
viclafargue 132acab
Multiple improvements
viclafargue fb82831
Adding nprobe parameter
viclafargue 729b3a4
Adding support for GpuIndexIVFFlat and GpuIndexIVFScalarQuantizer
viclafargue 2fa57fa
Completing documentation
viclafargue 5c44a18
Small fixes
viclafargue 8a46e42
Merge branch 'branch-0.16' into fea-multiple-knn-strategies
viclafargue 9c05d87
Adding test
viclafargue fa7d004
Improving tests
viclafargue 2c66690
Corrections & improvements
viclafargue 51362a7
Check style
viclafargue 5837cc8
Update changelog
viclafargue 49bb435
Adding include
viclafargue 0d3cfe1
Merge branch-0.16
viclafargue f39cc21
First part of requested changes
viclafargue 1a3af42
ANN parameters creation in separate file
viclafargue 636ce58
Updating ANN methods documentation
viclafargue 71b84f9
Merge branch-0.17
viclafargue bbff2c2
update related to raft
viclafargue 1ef5fd5
Merge branch 'branch-0.17' into fea-multiple-knn-strategies
viclafargue 1bb95df
Update changelog
viclafargue 5eb0060
Merge branch-0.18
viclafargue 046a127
Automated parameter determination to Python code
viclafargue c60d54c
Update changelog according to PR name
viclafargue 96bddef
Lower values for ivfpq testing + testing trim down
viclafargue 8775a42
Merge branch 'branch-0.18' into fea-multiple-knn-strategies
viclafargue 6a97101
Update ivfpq test
viclafargue 7e8ee31
Force index memory release in tests
viclafargue 937e799
Merge branch 'branch-0.18' into fea-multiple-knn-strategies
viclafargue 902849d
Removing changelog update
cjnolet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either before or shortly after this PR is merged, we need to update FAISS in cuML and use their new pluggable memory manager feature (facebookresearch/faiss#1203). While the brute-force computation uses only a very small workspace, the approximate
Index
variants put FAISS in complete control of the memory space of the index (through theStandardGPUResources
).