-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Moving linalg
decomp to RAFT namespaces
#2906
Conversation
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #2906 +/- ##
===============================================
+ Coverage 58.86% 58.87% +0.01%
===============================================
Files 143 143
Lines 9004 9004
===============================================
+ Hits 5300 5301 +1
+ Misses 3704 3703 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor updates, and a couple formatting questions; other than that LGTM.
Looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approval needed from cpp-codeowners
This moves the following:
linalg/eig.cuh
linalg/svd.cuh
linalg/qr.cuh
Major changes involve API change (adding a handle param to the function signature, and removing cublasHandle_t, allocator, etc.). This change is performed in all files mentioned above