Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Adding power_t param to SGD failing pytests #3012

Merged
merged 2 commits into from
Oct 18, 2020

Conversation

divyegala
Copy link
Member

SGDClassifier pytests were failing in CI for the specific test params, lrate=invscaling and loss=log. This was occurring due to floating point errors where values like 0.50xx would cause a misclassification. To resolve this, I simply increased the learning rate of the problem. For invscaling, lrate = eta0 / (pow(t, power_t), where eta0 and power_t are configurable parameters. Reducing power_t to 0.4 from its default of 0.5 was enough for the solution to converge for these pytests.

@divyegala divyegala requested a review from a team as a code owner October 17, 2020 02:04
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@codecov-io
Copy link

codecov-io commented Oct 17, 2020

Codecov Report

Merging #3012 into branch-0.17 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.17    #3012   +/-   ##
============================================
  Coverage        58.87%   58.87%           
============================================
  Files              143      143           
  Lines             9004     9004           
============================================
  Hits              5301     5301           
  Misses            3703     3703           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a7305...b473878. Read the comment docs.

@dantegd dantegd merged commit 5beaaae into rapidsai:branch-0.17 Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants