[REVIEW] Adding power_t
param to SGD failing pytests
#3012
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SGDClassifier
pytests were failing in CI for the specific test params,lrate=invscaling
andloss=log
. This was occurring due to floating point errors where values like0.50xx
would cause a misclassification. To resolve this, I simply increased the learning rate of the problem. Forinvscaling
,lrate = eta0 / (pow(t, power_t)
, whereeta0
andpower_t
are configurable parameters. Reducingpower_t
to0.4
from its default of0.5
was enough for the solution to converge for these pytests.