Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Correct if syntax in upload script [skip-ci] #3034

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Conversation

mike-wendt
Copy link
Contributor

@mike-wendt mike-wendt commented Oct 21, 2020

To use && we need double brackets otherwise it is interpreted as two separate commands. Updating the other if statements to match for consistency.

Current output from an upload attempt without this fix:

01:59:21.168 gpuCI logger » [10/21/2020 12:38:10]
01:59:21.168 ┌──────────────────────────────┐
01:59:21.168 |    Starting conda uploads    |
01:59:21.169 └──────────────────────────────┘
01:59:21.169 
01:59:21.169 +++ '[' 1 == 1
01:59:21.169 ci/cpu/upload.sh: line 41: [: missing `]'
01:59:21.169 +++ '[' 1 == 1
01:59:21.169 ci/cpu/upload.sh: line 48: [: missing `]'

To use `&&` we need double brackets otherwise it is interpreted as two separate commands. Updating the other if statements to match for consistency.
@mike-wendt mike-wendt requested a review from a team as a code owner October 21, 2020 14:24
@mike-wendt mike-wendt self-assigned this Oct 21, 2020
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@mike-wendt mike-wendt added 3 - Ready for Review Ready for review by team bug Something isn't working gpuCI gpuCI issue labels Oct 21, 2020
@mike-wendt mike-wendt merged commit 6690073 into branch-0.16 Oct 21, 2020
@mike-wendt mike-wendt deleted the fix-uploads branch October 21, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working gpuCI gpuCI issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants