[REVIEW] Speeding up MNMG KNN Cl&Re testing #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
JohnZed
requested changes
Oct 23, 2020
| @pytest.mark.parametrize("n_neighbors", [1, 3, 8]) | ||
| @pytest.mark.parametrize("n_parts", [2, 4, 12]) | ||
| @pytest.mark.parametrize("batch_size", [128, 1024]) | ||
| @pytest.mark.parametrize("n_neighbors", [8]) |
There was a problem hiding this comment.
Testing the degrenerate n_neighbors=1 case to me seems important. I always like to test the extremes. What about doing mark_parametrize with a list of tuples, like:
[(1, 3, 256),
(8, 8, 256),
(9, 3, 128)]
Then you still only run 3 times but still examine the extremes
| @pytest.mark.parametrize("n_neighbors", [1, 3, 8]) | ||
| @pytest.mark.parametrize("n_parts", [2, 4, 12]) | ||
| @pytest.mark.parametrize("batch_size", [128, 1024]) | ||
| @pytest.mark.parametrize("n_neighbors", [8]) |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #3052 +/- ##
============================================
Coverage 59.20% 59.20%
============================================
Files 142 142
Lines 8966 8966
============================================
Hits 5308 5308
Misses 3658 3658 Continue to review full report at Codecov.
|
viclafargue
changed the title
viclafargue
added
the
4 - Waiting on Reviewer
viclafargue
changed the title
JohnZed
approved these changes
Nov 2, 2020
| @pytest.mark.parametrize("batch_size", [128, 1024]) | ||
| def test_predict_proba(dataset, datatype, n_neighbors, | ||
| n_parts, batch_size, client): | ||
| @pytest.mark.parametrize("parameters", [(1, 3, 256), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answers #3028