Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Reducing dask coordinate descent test runtime #3074

Merged
merged 2 commits into from
Oct 29, 2020
Merged

[REVIEW] Reducing dask coordinate descent test runtime #3074

merged 2 commits into from
Oct 29, 2020

Conversation

Nanthini10
Copy link
Contributor

@Nanthini10 Nanthini10 commented Oct 28, 2020 •
edited
Loading

It already seems to be minimal, removing a few redundant values.

Runtime on my machine went from 72 seconds to 45 seconds

Closes #3043

@Nanthini10 Nanthini10 requested a review from a team as a code owner October 28, 2020 14:00
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@Nanthini10 Nanthini10 changed the title Reducing dask coordinate descent test runtime [REVIEW] Reducing dask coordinate descent test runtime Oct 28, 2020
@Nanthini10 Nanthini10 added the 3 - Ready for Review Ready for review by team label Oct 28, 2020
dantegd
dantegd requested changes Oct 29, 2020
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just one request to "stress" test the small data size before merging

python/cuml/test/dask/test_coordinate_descent.py
@pytest.mark.parametrize('algorithm', ['cyclic', 'random'])
@pytest.mark.parametrize('nrows', [unit_param(500),
@pytest.mark.parametrize('nrows', [unit_param(50),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but I worry a little bit about the small data size could create some brittleness in the test. @Nanthini10 could you use pytest-repeat to run the test locally for a number of times (say 100 at least) just to confirm that the test is still robust and for peace of mind?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dantegd Ran it a 100 times and it passed the tests 👍

@dantegd dantegd added 4 - Waiting on Author Waiting for author to respond to review tests Unit testing for project and removed 3 - Ready for Review Ready for review by team labels Oct 29, 2020
@Nanthini10 Nanthini10 added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels Oct 29, 2020
@Nanthini10 Nanthini10 requested a review from dantegd October 29, 2020 19:23
@Nanthini10
Copy link
Contributor Author

rerun tests

@dantegd dantegd added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Waiting on Reviewer Waiting for reviewer to review or respond labels Oct 29, 2020
@codecov-io
Copy link

Codecov Report

Merging #3074 into branch-0.17 will increase coverage by 0.84%.
The diff coverage is 96.15%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3074      +/-   ##
===============================================
+ Coverage        58.39%   59.23%   +0.84%     
===============================================
  Files              143      142       -1     
  Lines             8897     8966      +69     
===============================================
+ Hits              5195     5311     +116     
+ Misses            3702     3655      -47
Impacted Files Coverage Δ
python/cuml/dask/solvers/cd.py 54.54% <ø> (+2.16%) ⬆️
python/cuml/thirdparty_adapters/adapters.py 88.44% <95.74%> (+6.20%) ⬆️
...l/_thirdparty/sklearn/preprocessing/_imputation.py 62.50% <100.00%> (-4.05%) ⬇️
python/cuml/thirdparty_adapters/__init__.py 100.00% <100.00%> (ø)
python/cuml/common/import_utils.py 61.95% <0.00%> (-2.42%) ⬇️
python/cuml/pytest_benchmarks/test_bench.py 100.00% <0.00%> (ø)
python/cuml/common/array.py 97.72% <0.00%> (+0.01%) ⬆️
python/cuml/metrics/_ranking.py 98.61% <0.00%> (+0.03%) ⬆️
python/cuml/preprocessing/encoders.py 95.18% <0.00%> (+0.07%) ⬆️
...on/cuml/_thirdparty/sklearn/preprocessing/_data.py 63.45% <0.00%> (+0.12%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3095587...a9df5e3. Read the comment docs.

@dantegd dantegd merged commit 7c6b142 into rapidsai:branch-0.17 Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TEST] Speed up dask.coordinate_descent test
4 participants
@Nanthini10 @GPUtester @codecov-io @dantegd