Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Speed up UMAP mnmg tests #3115

Merged
merged 4 commits into from
Nov 5, 2020
Merged

[REVIEW] Speed up UMAP mnmg tests #3115

merged 4 commits into from
Nov 5, 2020

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Nov 4, 2020

Lowering the number of data samples and removing some redundant parametrizations to speed up UMAP mnmg tests (and lower its memory usage).

@cjnolet cjnolet added 3 - Ready for Review Ready for review by team tests Unit testing for project Cython / Python Cython or Python issue Tech Debt Issues related to debt labels Nov 4, 2020
@cjnolet cjnolet requested a review from a team as a code owner November 4, 2020 20:00
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

dantegd
dantegd approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm

@dantegd dantegd added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 4, 2020
@codecov-io
Copy link

Codecov Report

Merging #3115 into branch-0.17 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.17    #3115   +/-   ##
============================================
  Coverage        59.20%   59.20%           
============================================
  Files              142      142           
  Lines             8966     8966           
============================================
  Hits              5308     5308           
  Misses            3658     3658
Impacted Files Coverage Δ
python/cuml/__init__.py 100.00% <100.00%> (ø)
python/cuml/metrics/__init__.py 100.00% <100.00%> (ø)
python/cuml/metrics/cluster/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63fc249...5e4c137. Read the comment docs.

@dantegd dantegd merged commit d9f86bc into rapidsai:branch-0.17 Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@JohnZed JohnZed JohnZed approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue Tech Debt Issues related to debt tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjnolet @GPUtester @codecov-io @JohnZed @dantegd